Review main Merged

39742[TASK] Add "select all" to EXT:recycler

Andreas Kienast CR +2 V +2 Normal +37 −30 updated 05/27/15, 15:27

Commit message

Re-add the "select all" toggle to select all records on a page.
The action buttons are moved to the right to match the common style
of the backend.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1
    • Christian Kuhn +1

Issues 1

Files 3

Review log 17

  1. Andreas Kienast uploaded patch set 1 05/26/15, 12:44

  2. Nicole Hummel voted on patch set 1 CR +1 V +1 05/26/15, 12:51

  3. Wouter Wolters voted on patch set 1 CR +1 05/26/15, 12:52

  4. Andreas Kienast commented on patch set 1 CR -1 05/26/15, 12:53

    Index.html:35

    oops...
  5. Andreas Kienast uploaded patch set 2 05/26/15, 12:54

  6. Nicole Hummel voted on patch set 2 CR +1 V +1 05/26/15, 13:04

  7. Wouter Wolters voted on patch set 2 CR +1 05/26/15, 13:04

  8. Christian Kuhn commented on patch set 2 V -1 05/26/15, 15:55

    somehow the table layout is a bit broken: the border at the right side of the collapsed row is not shown any longer. see screeni in forge.
  9. Andreas Kienast commented on patch set 2 05/26/15, 17:26

    lolli, that's a known issue and unrelated to that patch. Problem here is, that .collapse is displayed as block element to prevent RTE issues but collides with collapsed table rows. You can verify this by expanding a row and close it again. U talked to Benji already, we're testing if setting the CSS to div.collapse is enough.
  10. Andreas Kienast commented on patch set 2 05/26/15, 17:27

    I talked to Benji... damn phone keyboard
  11. Christian Kuhn voted on patch set 2 CR +1 V +1 05/27/15, 15:01

  12. Markus Klein commented on patch set 2 V -1 05/27/15, 15:23

    Button alignment is bad.
  13. Andreas Kienast uploaded patch set 3 05/27/15, 15:24

  14. Markus Klein voted on patch set 3 CR +1 V +1 05/27/15, 15:25

  15. Christian Kuhn voted on patch set 3 CR +1 V +1 05/27/15, 15:26

  16. Andreas Kienast voted on patch set 3 CR +2 V +2 05/27/15, 15:27

  17. Andreas Kienast merged patch set 3 05/27/15, 15:27