39743[BUGFIX] Allow removal of search term in Page / List module
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Philipp Gampe +1
-
Verified V +2
- Frank Nägler +2
- Philipp Gampe +1
Issues 1
Files 2
Review log 7
-
Andreas Kienast uploaded patch set 1 05/26/15, 13:52
-
Christian Kuhn commented on patch set 1 05/26/15, 14:23
it would be worth mentioning this is the search box in list / page module that is below the docheader. this is not clear from reading "Allow removal of search term" -
Andreas Kienast updated the commit message in patch set 2 05/26/15, 14:39
-
Philipp Gampe commented on patch set 2 CR +1 V +1 05/30/15, 09:08
Works. Will there be further usebility improvements? e.g. clear input icon and autofocus after clicking the search button on the docheader? -
Andreas Kienast commented on patch set 2 05/31/15, 18:13
Of course :) But we have to decouple it from the PHP code and make a RequireJS module out of it. -
Frank Nägler voted on patch set 2 V +2 CR +2 06/01/15, 10:05
-
Frank Nägler merged patch set 2 06/01/15, 10:05