39744[BUGFIX] Import Selection with TYPO3 Element Browser
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Andreas Kienast +1
-
Verified V +2
- Markus Klein +2
- Andreas Kienast +1
Issues 1
Files 2
Review log 17
-
Frank Nägler uploaded patch set 1 05/26/15, 14:08
-
Frank Nägler commented on patch set 1 05/26/15, 14:12
This fix works atm only for master, for 6.2 we need to backport this fix to the browse_links.js. Not sure if this fix has any impact, I searched within the core, but can't find another place where the changed method is called. -
Andreas Kienast commented on patch set 1 05/26/15, 14:44
Can we remove the `insertElementMultiple` function then? -
Markus Klein commented on patch set 1 05/26/15, 17:04
This needs to be tested with FAL and non-FAL. -
Wouter Wolters commented on patch set 1 05/26/15, 20:48
non-fal -> tt_news -
Frank Nägler commented on patch set 1 V -1 05/26/15, 21:10
Adding multiple images on a news record, did work. -
Frank Nägler commented on patch set 1 05/26/15, 21:53
will check the JS rendering tomorrow again, maybe there is no simple solution without bigger refactoring. -
Frank Nägler uploaded patch set 2 05/30/15, 18:03
-
Frank Nägler commented on patch set 2 05/30/15, 18:07
The new version works with IRRE and with group fields. Please be aware of the browser caches! Sometimes I thought it not works, but the browser cache contain only old versions of the JS file. While testing be sure to clear all your caches! -
Markus Klein commented on patch set 2 05/30/15, 22:17
BrowseLinks.js:85is that necessary?ElementBrowser.php:771we can skip one pair of (), which makes this more readable -
Xavier Perseguers commented on patch set 2 06/01/15, 05:44
fixESBrowseLinks.js:88other parts of the code add spaces around "=", "<", would prefer to stay uniform -
Xavier Perseguers commented on patch set 2 06/01/15, 05:48
taking care...BrowseLinks.js:85Replycode is var _hasActionMultipleCode = ' . ((!empty($JScodeActionMultiple)) ? 'true' : 'false') . '; so NO. -
Xavier Perseguers uploaded patch set 3 06/01/15, 05:49
-
Markus Klein voted on patch set 3 CR +1 06/01/15, 07:29
-
Andreas Kienast commented on patch set 3 CR +1 V +1 06/02/15, 09:26
Tested as described by Markus here: https://forge.typo3.org/issues/47322#note-15 -
Markus Klein voted on patch set 3 CR +2 V +2 06/02/15, 21:19
-
Markus Klein merged patch set 3 06/02/15, 21:19