Review TYPO3_6-2 Merged

39746[BUGFIX] Set background for disabled input fields

Andreas Kienast CR +2 V +2 Easy +8 −1 updated 08/10/15, 05:57

Commit message

Set a proper background color for disabled input fields.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 13

  1. Andreas Kienast uploaded patch set 1 05/26/15, 14:29

  2. Andreas Kienast updated the commit message in patch set 2 05/26/15, 14:40

  3. Daniel Goerz voted on patch set 2 CR +1 08/06/15, 18:39

  4. Daniel Goerz voted on patch set 2 V +1 08/06/15, 18:48

  5. Benni Mack voted on patch set 2 CR +2 08/06/15, 22:13

  6. Christian Kuhn commented on patch set 2 08/07/15, 08:21

    A user asked in the ticket if select:disabled could be added, too.
  7. Benni Mack commented on patch set 2 V -1 08/07/15, 12:01

    this won't work in IE8
  8. Daniel Goerz commented on patch set 2 08/09/15, 08:28

    > this won't work in IE8 Looks like IE8 wont work no matter what (see: http://stackoverflow.com/questions/1411044/how-to-change-color-of-disabled-html-controls-in-ie8-using-css) So how about fixing it in the remaining browsers?
  9. Daniel Goerz commented on patch set 2 08/09/15, 08:31

    Ignore my last comment, I missread color for background-color.
  10. Daniel Goerz uploaded patch set 3 08/09/15, 08:44

  11. Daniel Goerz voted on patch set 3 V +1 CR +1 08/09/15, 08:45

  12. Benni Mack voted on patch set 3 CR +2 V +2 08/10/15, 05:57

  13. Benni Mack merged patch set 3 08/10/15, 05:57