Review main Merged

39767[FOLLOWUP][BUGFIX] Show full folder path in file list title

Frans Saris CR +2 V +2 Easy +9 −4 updated 06/02/15, 17:45

Commit message

In old situation the full path to of the folder was shown.
With #64759 only the accessible part is shown. The logic
to determine what the root is of the 'current' filemount
is not suitable for this and will always return the root path of
the first filemount within the storage. This could result in a wrong
root identifier.

This patch fixes the output of the readable path to the
full path by using the real storage root instead of the storage root
defined by the filemount.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Xavier Perseguers +1
  • Verified V +2
    • Frank Nägler +2
    • Xavier Perseguers +1

Issues 2

Files 2

Review log 19

  1. Frans Saris uploaded patch set 1 05/28/15, 06:58

  2. Wouter Wolters commented on patch set 1 05/28/15, 07:03

    accessible
    fixes or changes, not both words
  3. Stefan Neufeind commented on patch set 1 05/28/15, 07:17

    ResourceStorage.php:2157

    So we assume even "no filemounts" is okay?
  4. Wouter Wolters updated the commit message in patch set 2 05/28/15, 07:28

  5. Wouter Wolters commented on patch set 2 05/28/15, 07:29

    ResourceStorage.php:2157

    !empty could be done here instead of count we can change it now but better would be a seperate patch
  6. Xavier Perseguers voted on patch set 2 CR +1 V +1 05/28/15, 07:40

  7. Stefan Neufeind voted on patch set 2 CR +1 05/28/15, 07:41

  8. Wouter Wolters voted on patch set 2 CR +1 05/28/15, 07:48

  9. Markus Klein commented on patch set 2 05/28/15, 10:25

    Do we really want that? Do I want the normal user to see the full path?
  10. Frans Saris commented on patch set 2 05/28/15, 13:02

    Reply

    This was also the behaviour before #64759 so kind of a regression on its own that also is fixed with this patch. If we do not want the full path it should be a different change.
  11. Frank Nägler commented on patch set 2 V -1 05/28/15, 22:03

    with and without the patch I still get the mentioned exception. My setup: - Introduction packages on current master Steps to reproduce: - Add One or more Filemounts to an editor user - Switch to the user - open File List -> Exception
  12. Frank Nägler voted on patch set 2 V +1 CR +1 05/29/15, 09:52

  13. Frank Nägler voted on patch set 2 V +2 CR +2 05/29/15, 09:54

  14. Frank Nägler merged patch set 2 05/29/15, 09:54

  15. Frans Saris commented on patch set 3 05/29/15, 09:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 97255fd576a5b4e7c42a96b6cd5cef7984da5f3a
  16. Nicole Hummel commented on patch set 3 06/02/15, 09:26

    Post -2 this adds an information disclosure. I don't want an editor to be able to see the whole path to a mount point!
  17. Markus Klein commented on patch set 3 06/02/15, 09:36

    @Nicole: had the same comment already. Please read Frans' response
  18. Nicole Hummel commented on patch set 3 06/02/15, 09:39

    TBH saying that is was always like that way is not secure and faithful neither! We have to change this immediately!
  19. Frans Saris commented on patch set 3 06/02/15, 17:45

    As the path of a folder is normally also exposed by the download link of files in the folder and the fact that this behaviour wasn't new but there since... was the reason why I didn't look further to get this adjusted/fixed in this patch. The revert preposed by Xavier also wouldn't help. IMO it is better to do the change in behaviour in a separate, dedicated patch. Makes it easier to track down issues after