Review main Merged

39786[TASK] Make SQL Schema Parser aware of combined indexes

Frank Nägler CR +2 V +2 Hard +338 −1 updated 06/03/15, 06:32

Commit message

The patch fix problems with multiple parenthesis. e.g.
uid_foreign,tablenames(255),fieldname(255),sorting_foreign

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 2

Review log 9

  1. Frank Nägler uploaded patch set 1 05/29/15, 09:32

  2. Frank Nägler voted on patch set 1 CR -2 05/29/15, 09:40

  3. Frank Nägler uploaded patch set 2 05/29/15, 10:56

  4. Frank Nägler voted on patch set 2 CR 0 05/29/15, 11:20

  5. Markus Klein commented on patch set 2 CR -1 05/29/15, 20:39

    SqlParser.php:1384

    {0,1} == ? in regex The \ needs to be escaped for PHP too => \\( use a non-capturing group for the number
  6. Markus Klein uploaded patch set 3 05/29/15, 20:45

  7. Markus Klein voted on patch set 3 CR +1 V +1 05/29/15, 20:47

  8. Andreas Kienast voted on patch set 3 CR +2 V +2 06/03/15, 06:32

  9. Andreas Kienast merged patch set 3 06/03/15, 06:32