Review main Merged

39866[TASK] Reduce duplicated paths for bowercopy

Mathias Brodala CR +2 V +2 Normal +31 −28 updated 06/01/15, 20:17

Commit message

This makes use of the destPrefix option to set the target base
path only once.

Also drop the leading slash from source path which is unnecessary.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 11

  1. Mathias Brodala uploaded patch set 1 06/01/15, 13:08

  2. Daniel Sattler voted on patch set 1 CR +1 06/01/15, 13:14

  3. Andreas Kienast commented on patch set 1 CR -1 06/01/15, 13:43

    No ticket, no chocolate ;)
  4. Mathias Brodala uploaded patch set 2 06/01/15, 13:47

  5. Mathias Brodala commented on patch set 1 06/01/15, 13:47

    ;-)

    Reply

    Done
  6. Andreas Kienast commented on patch set 2 CR -1 06/01/15, 13:52

    Gruntfile.js:47

    missing ":", I do a followup
  7. Andreas Kienast uploaded patch set 3 06/01/15, 13:53

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 06/01/15, 13:53

  9. Wouter Wolters voted on patch set 3 CR +1 06/01/15, 14:15

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 06/01/15, 20:17

  11. Wouter Wolters merged patch set 3 06/01/15, 20:17