39877[FEATURE] Emit Signal when an IndexRecord is marked as missing
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 13
-
Christian Reiter uploaded patch set 1 06/02/15, 09:04
-
Andreas Kienast commented on patch set 1 CR -1 06/02/15, 09:33
Thank you for this change. Can you please add a ReST file documenting the new feature as described here: http://wiki.typo3.org/TYPO3_CMS_Important_Changes_Documentation_HowTo -
Andreas Kienast commented on patch set 1 06/02/15, 09:35
I forgot: There is a tool that assists you in writing the documentation file: https://forger.typo3.org/standard/rst -
Christian Reiter commented on patch set 1 06/02/15, 10:18
How do properly commit the rst file? With "Related: #..." in the commit message? Could the ReST doc requirement and the tool link perhaps be added to the Contributon Walkthrough pages? This would assist people who are not regular committers. -
Andreas Kienast commented on patch set 1 06/02/15, 10:34
I agree on this, were currently rewriting the contribution page. You can simply put the .rst file into `sysext/core/Documentation/Changelog/master`, ammend the commit and push again, there's no need to relate it in the commit message. -
Christian Reiter commented on patch set 1 06/02/15, 10:45
I've already added & committed the rst at that place in my local branch, so I guess i can't amend the original commit anymore. Is it possbile to push it as a separate commit or how do I proceed (I am not a git magician) -
Andreas Kienast commented on patch set 1 06/02/15, 11:20
Store the rst file on a safe place, like your desktop. Now do a hard-reset to get a clean master again: `git reset --hard origin/master`. Then cherry-pick this patch, you'll get the cli command by clicking on "Download". After that, move the stored file back to the destination, add the file to git, amend the commit by `git commit --amend` and push it. If you have further questions, feel free to join us on Slack: https://forger.typo3.org/slack and join the #typo3-cms-coredev channel. -
Christian Reiter uploaded patch set 2 06/02/15, 11:46
-
Christian Reiter commented on patch set 2 06/03/15, 08:42
rst is now supplied -
Christian Kuhn uploaded patch set 3 06/25/15, 22:43
-
Christian Kuhn commented on patch set 3 CR +1 V +1 06/25/15, 22:44
Looks good to me. Could a FAL person have a second eye? -
Frank Nägler voted on patch set 3 V +2 CR +2 06/26/15, 09:29
-
Frank Nägler merged patch set 3 06/26/15, 09:30