Review main Abandoned

39886[BUGFIX] Check if cache exists before calling it

Andreas Kienast CR 0 V 0 Easy +5 −3 updated 07/19/15, 10:11

Commit message

Before the CacheManager can call the cache it must be checked
whether the cache exists.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Andreas Kienast uploaded patch set 1 06/02/15, 10:52

  2. Christian Kuhn commented on patch set 1 06/02/15, 11:44

    mmh, not a big fan on reading. i'll have a deeper look at the issue, too.
  3. Wouter Wolters commented on patch set 1 06/03/15, 18:40

    This looks more like the cacheManager is not initialized when the getDatabaseTableDefinitions funcion is called
  4. Markus Sommer voted on patch set 1 CR +1 V +1 06/05/15, 09:02

  5. Frank Nägler commented on patch set 1 CR -1 06/05/15, 09:17

    dislike, looks like a configuration or loading issue. The main questions is: why it is called with an identifier which not exist?
  6. Markus Klein commented on patch set 1 CR -1 06/05/15, 09:24

    Agree with Frank. The real issue is that a cache is expected to exist, but is not there.
  7. Markus Sommer commented on patch set 1 CR -1 V -1 07/19/15, 09:23

    Obsolate in master This Class is removed
  8. Anja Leichsenring abandoned the change 07/19/15, 10:11

    abandoned due to being obsolete