Review main Merged

39896[CLEANUP] Correct case for SimpleXMLElement

Stephan Großberndt CR +2 V +2 Easy +2 −2 updated 06/03/15, 16:00

Commit message

Use the correct case 'SimpleXMLElement' instead of 'SimpleXmlElement'
when loading locallang.xml and remove backslashes for options.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 2

Files 2

Review log 20

  1. Stephan Großberndt uploaded patch set 1 06/02/15, 13:23

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 06/02/15, 13:24

  3. Christian Kuhn commented on patch set 1 06/02/15, 13:40

    does this patch really solve the nfs issue??
  4. Markus Klein commented on patch set 1 06/02/15, 13:45

    To my understanding this was just a sidenote of the ticket author.
  5. Stephan Großberndt uploaded patch set 2 06/02/15, 13:48

  6. Stephan Großberndt commented on patch set 2 06/02/15, 13:52

    now Resolves: #67242 Related: #67234
  7. Stephan Großberndt updated the commit message in patch set 3 06/02/15, 13:52

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 06/02/15, 13:59

  9. Markus Klein commented on patch set 3 CR -1 06/02/15, 16:11

    AbstractXmlParser.php:103

    wrong too

    LocallangXmlParser.php:165

    IMO this \ is wrong too, that is a constant and not a class.
  10. Stephan Großberndt uploaded patch set 4 06/03/15, 11:53

  11. Markus Klein voted on patch set 4 V +1 CR +1 06/03/15, 11:59

  12. Christian Kuhn commented on patch set 4 06/03/15, 14:50

    both LIBXML_NOWARNING and \LIBXML_NOWARNING resolve to 64. this change is cosmetical and does not change anything. no backport to 6.2
  13. Christian Kuhn updated the commit message in patch set 5 06/03/15, 14:50

  14. Christian Kuhn voted on patch set 5 CR +1 V +1 06/03/15, 14:50

  15. Stephan Großberndt updated the commit message in patch set 6 06/03/15, 14:50

  16. Stephan Großberndt commented on patch set 6 06/03/15, 14:51

    SimpleXmlElement is still wrong for 6.2
  17. Stephan Großberndt updated the commit message in patch set 7 06/03/15, 14:54

  18. Christian Kuhn voted on patch set 7 CR +1 V +1 06/03/15, 14:58

  19. Markus Klein voted on patch set 7 CR +2 V +2 06/03/15, 16:00

  20. Markus Klein merged patch set 7 06/03/15, 16:00