Review main Merged

39898[BUGFIX] Prevent information disclosure in file list

Nicole Hummel CR +2 V +2 Easy +8 −6 updated 08/13/15, 15:19

Commit message

Currently the doc header title of a folder shows the full path even
if the current folder is inside a mount point. This patch prevents
showing the full path by not disabling the permission check but catch
a thrown exception and return the path inside the mount point.

Review

  • Code review CR +2
    • Susi Moog +2
    • Markus Klein +1
  • Verified V +2
    • Susi Moog +2
    • Harry Glatz +1

Issues 1

Files 1

Review log 12

  1. Nicole Hummel uploaded patch set 1 06/02/15, 14:33

  2. Markus Klein commented on patch set 1 06/02/15, 14:39

    Folder.php:115

    May not have access
  3. Frans Saris commented on patch set 1 CR -1 V -1 06/02/15, 16:24

    Folder.php:108

    This doesn't work for users with multiple filemount in the same storage as getRootLevelFolder() doesn't recognise current filemount but will return first filemount. that was the reason for the follow up https://forge.typo3.org/issues/67148#note-8. Looks like the only solution would be to walk up the the "folder path" until you hit a no permissions exception or the identifier of the parent folder is the same as the "current" folder
  4. Frans Saris commented on patch set 1 06/02/15, 16:31

    Folder.php:108 Reply

    Only keeping the FALSE for getRootLevelFolder should be enough. Untested
  5. Nicole Hummel commented on patch set 1 07/16/15, 09:51

    Folder.php:108 Reply

    I don't see any problem here. I've tested this again with a user with two file mounts of the same storage and it works.
  6. Nicole Hummel uploaded patch set 2 07/16/15, 09:51

  7. Markus Klein voted on patch set 2 CR +1 07/16/15, 18:35

  8. Harry Glatz voted on patch set 2 V +1 07/17/15, 13:54

  9. Susi Moog commented on patch set 2 CR +2 V +2 07/17/15, 14:51

    looks fine to me, the only thing I found (which is already somehow broken without this patch) is if you have two file mounts with the same label - but that has nothing to do with this patch.
  10. Susi Moog merged patch set 2 07/17/15, 14:51

  11. Stephan Großberndt commented on patch set 3 08/12/15, 18:07

    TYPO3 6.2 is in Releases but the patch has not been backported. Is there a reason?
  12. Stephan Großberndt commented on patch set 3 08/13/15, 15:19