Review main Merged

39910[BUGFIX] addToAllTCAtypes() must replace fields correctly

Markus Klein CR +2 V +2 Easy +25 −6 updated 06/03/15, 15:13

Commit message

The changes made in #57824 cause the replace functionality to fail.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • rengaw83 +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 9

  1. Markus Klein uploaded patch set 1 06/03/15, 08:42

  2. Markus Klein uploaded patch set 2 06/03/15, 08:58

  3. Wouter Wolters voted on patch set 2 CR +1 06/03/15, 11:42

  4. rengaw83 voted on patch set 2 CR +1 06/03/15, 12:39

  5. Alexander Opitz voted on patch set 2 V +1 CR +2 06/03/15, 14:54

  6. Christian Kuhn commented on patch set 2 06/03/15, 15:04

    ExtensionManagementUtilityTest.php:392

    hint: 3rd parameter "message" is usually not used in our core assertions (only in rare cases this is useful): the method name typically should suffice. ... but can be kept for this patch, since it occurs above as well ...
  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/03/15, 15:12

  8. Christian Kuhn merged patch set 2 06/03/15, 15:12

  9. Christian Kuhn commented on patch set 3 06/03/15, 15:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 41bd0b1da96aaf1025778b0bea48d805183b1eec