Review main Merged

39916[BUGFIX] Clear cache_treelist table in Install Tool

Wouter Wolters CR +2 V +2 Easy +4 −0 updated 06/03/15, 20:33

Commit message

This is not implemented in the caching framework and
needs to be cleared manually.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 1

Review log 9

  1. Wouter Wolters uploaded patch set 1 06/03/15, 11:25

  2. Markus Klein voted on patch set 1 CR +1 V +1 06/03/15, 11:33

  3. Christian Kuhn commented on patch set 1 CR -1 06/03/15, 14:57

    ok, this is ugly anyway. i hope we can get rid of cache_treelist altogether later. until then, a patch like that is probably the best option. however, i would prefer if the code verifies this table exists before it truncates, first: ext:frontend is a required extension at the moment, but better safe than sorry here, imho. -1 for now, should be ok as soon as table existence is verified.
  4. Wouter Wolters commented on patch set 1 06/03/15, 15:00

    Sorry but this makes no sense at all. This code is copied from datahandler!! No need to add extra code here!
  5. Wouter Wolters uploaded patch set 2 06/03/15, 17:56

  6. Markus Klein voted on patch set 2 CR +1 V +1 06/03/15, 17:59

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/03/15, 20:32

  8. Christian Kuhn merged patch set 2 06/03/15, 20:32

  9. Christian Kuhn commented on patch set 3 06/03/15, 20:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0815501e02b86dff39259219deef58453742be66