Review main Merged

39927[BUGFIX] Capability check fails for some storage types

Andreas Wolf CR +2 V +2 Easy +2 −2 updated 08/12/15, 19:33

Commit message

The check should only complain if a user wants to mark a storage as
public and the driver does not support that. This commit changes the
check accordingly.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 1

Review log 14

  1. Andreas Wolf uploaded patch set 1 06/03/15, 18:02

  2. Wouter Wolters commented on patch set 1 06/03/15, 18:05

    which releases is this bugfix targeted to?
  3. Andreas Kienast commented on patch set 1 CR -1 06/04/15, 07:26

    UserStorageCapabilityService.php:46

    Please cast to (bool) instead: (bool)$storageRecord['is_public'] && ...
  4. Andreas Wolf uploaded patch set 2 06/05/15, 07:14

  5. Andreas Wolf commented on patch set 1 06/05/15, 07:16

    Added releases and cast as noted by Andi and Wouter.

    UserStorageCapabilityService.php:46 Reply

    Done
  6. Andreas Kienast uploaded patch set 3 06/05/15, 07:52

  7. Andreas Kienast voted on patch set 3 CR +1 06/05/15, 07:53

  8. Markus Klein commented on patch set 3 07/22/15, 20:17

    UserStorageCapabilityService.php:43

    no need for this cast here

    UserStorageCapabilityService.php:46

    same here
  9. Markus Klein uploaded patch set 4 07/27/15, 09:24

  10. Markus Klein voted on patch set 4 V +1 CR +1 07/27/15, 09:26

  11. Wouter Wolters voted on patch set 4 CR +1 07/27/15, 11:21

  12. Stefan Neufeind voted on patch set 4 CR +1 07/28/15, 20:41

  13. Benni Mack voted on patch set 4 CR +2 V +2 08/12/15, 19:33

  14. Benni Mack merged patch set 4 08/12/15, 19:33