39927[BUGFIX] Capability check fails for some storage types
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
Issues 1
Files 1
Review log 14
-
Andreas Wolf uploaded patch set 1 06/03/15, 18:02
-
Wouter Wolters commented on patch set 1 06/03/15, 18:05
which releases is this bugfix targeted to? -
Andreas Kienast commented on patch set 1 CR -1 06/04/15, 07:26
UserStorageCapabilityService.php:46Please cast to (bool) instead: (bool)$storageRecord['is_public'] && ... -
Andreas Wolf uploaded patch set 2 06/05/15, 07:14
-
Andreas Wolf commented on patch set 1 06/05/15, 07:16
Added releases and cast as noted by Andi and Wouter.UserStorageCapabilityService.php:46ReplyDone -
Andreas Kienast uploaded patch set 3 06/05/15, 07:52
-
Andreas Kienast voted on patch set 3 CR +1 06/05/15, 07:53
-
Markus Klein commented on patch set 3 07/22/15, 20:17
UserStorageCapabilityService.php:43no need for this cast hereUserStorageCapabilityService.php:46same here -
Markus Klein uploaded patch set 4 07/27/15, 09:24
-
Markus Klein voted on patch set 4 V +1 CR +1 07/27/15, 09:26
-
Wouter Wolters voted on patch set 4 CR +1 07/27/15, 11:21
-
Stefan Neufeind voted on patch set 4 CR +1 07/28/15, 20:41
-
Benni Mack voted on patch set 4 CR +2 V +2 08/12/15, 19:33
-
Benni Mack merged patch set 4 08/12/15, 19:33