Review main Merged

39964[BUGFIX] Change default label for sys_file_references

Bernd Wilke CR +2 V +2 Easy +3 −3 updated 06/19/15, 21:04

Commit message

In the List module you can select additional fields to be displayed.
For fields referencing files only, the uid is shown which does give
no hint to the real referenced file.
This change selects the uid_local field, which selects the filename
from sys_file for display.

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1

Issues 1

Files 3

Review log 27

Show 2 earlier messages
  1. Bernd Wilke uploaded patch set 1 06/05/15, 09:25

  2. Markus Klein updated the commit message in patch set 2 06/05/15, 09:50

  1. Markus Klein voted on patch set 2 CR +1 06/05/15, 09:52

  2. Wouter Wolters voted on patch set 2 CR +1 06/05/15, 09:52

  3. Jan Helke updated the commit message in patch set 3 06/05/15, 09:52

  4. Jan Helke voted on patch set 3 CR +1 06/05/15, 09:53

  5. Markus Klein updated the commit message in patch set 4 06/05/15, 09:53

  6. Markus Klein voted on patch set 4 CR +1 06/05/15, 09:53

  7. Jan Helke voted on patch set 4 CR +1 06/05/15, 09:54

  8. Cedric Ziel voted on patch set 4 CR +1 06/05/15, 09:57

  9. Stefan Neufeind commented on patch set 4 CR +1 V +1 06/06/15, 15:55

    Title is shown in addition to the uid. Thus I'm fine to also have it for 6.2 (adds value to a behaviour which didn't make sense in the past). But it's not an "important" change, so I could also understand if others argue it shouldn't get into 6.2 I also wondered if we shouldn't show the uid at all, since the backend-user doesn't have much benefit from it.
  10. Markus Klein commented on patch set 4 CR 0 06/06/15, 16:16

    Hm... after testing I agree with Stefan. I actually don't want to see the uid at all.
  11. Stefan Neufeind uploaded patch set 5 06/06/15, 16:51

  12. Stefan Neufeind commented on patch set 5 CR +1 V +1 06/06/15, 16:52

    Now without uid, just the filename. I'd suggest we only do that for master then?
  13. Markus Klein commented on patch set 5 06/06/15, 17:03

    I would go for 6.2 as well, as the uid list is just plain non-sense for the GUI.
  14. Markus Klein commented on patch set 5 V -1 06/06/15, 22:47

  15. Stefan Neufeind uploaded patch set 6 06/07/15, 11:31

  16. Stefan Neufeind commented on patch set 6 CR +1 V +1 06/07/15, 11:32

    Reapplying my vote for the code. After running the functional tests I still had one failing, which I fixed afterwards - but rerunning them here again would take ages :-( I hope they are fine now.
  17. Stefan Neufeind commented on patch set 6 V -1 06/07/15, 11:48

  18. Stefan Neufeind commented on patch set 6 06/07/15, 11:52

    Hmm, what is it that goes wrong in EXT:workspaces?
  19. Benni Mack updated the commit message in patch set 7 06/19/15, 13:51

  20. Benni Mack voted on patch set 7 CR +1 V +1 06/19/15, 13:51

  21. Markus Klein voted on patch set 7 CR +2 V +2 06/19/15, 20:47

  22. Markus Klein merged patch set 7 06/19/15, 20:48

  23. Markus Klein commented on patch set 8 06/19/15, 21:01

    Functional tests broken. I'll revert
  24. Markus Klein commented on patch set 8 06/19/15, 21:01

    Reverted This patchset was reverted in change: Ief8de9603ee1faf68f763c43b1cb48b72fa80ae1
  25. Markus Klein commented on patch set 8 06/19/15, 21:04