39964[BUGFIX] Change default label for sys_file_references
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Benni Mack +1
-
Verified V +2
- Markus Klein +2
- Benni Mack +1
Issues 1
Files 3
Review log 27
Show 2 earlier messages
-
Markus Klein voted on patch set 2 CR +1 06/05/15, 09:52
-
Wouter Wolters voted on patch set 2 CR +1 06/05/15, 09:52
-
Jan Helke updated the commit message in patch set 3 06/05/15, 09:52
-
Jan Helke voted on patch set 3 CR +1 06/05/15, 09:53
-
Markus Klein updated the commit message in patch set 4 06/05/15, 09:53
-
Markus Klein voted on patch set 4 CR +1 06/05/15, 09:53
-
Jan Helke voted on patch set 4 CR +1 06/05/15, 09:54
-
Cedric Ziel voted on patch set 4 CR +1 06/05/15, 09:57
-
Stefan Neufeind commented on patch set 4 CR +1 V +1 06/06/15, 15:55
Title is shown in addition to the uid. Thus I'm fine to also have it for 6.2 (adds value to a behaviour which didn't make sense in the past). But it's not an "important" change, so I could also understand if others argue it shouldn't get into 6.2 I also wondered if we shouldn't show the uid at all, since the backend-user doesn't have much benefit from it. -
Markus Klein commented on patch set 4 CR 0 06/06/15, 16:16
Hm... after testing I agree with Stefan. I actually don't want to see the uid at all. -
Stefan Neufeind uploaded patch set 5 06/06/15, 16:51
-
Stefan Neufeind commented on patch set 5 CR +1 V +1 06/06/15, 16:52
Now without uid, just the filename. I'd suggest we only do that for master then? -
Markus Klein commented on patch set 5 06/06/15, 17:03
I would go for 6.2 as well, as the uid list is just plain non-sense for the GUI. -
Markus Klein commented on patch set 5 V -1 06/06/15, 22:47
-
Stefan Neufeind uploaded patch set 6 06/07/15, 11:31
-
Stefan Neufeind commented on patch set 6 CR +1 V +1 06/07/15, 11:32
Reapplying my vote for the code. After running the functional tests I still had one failing, which I fixed afterwards - but rerunning them here again would take ages :-( I hope they are fine now. -
Stefan Neufeind commented on patch set 6 V -1 06/07/15, 11:48
-
Stefan Neufeind commented on patch set 6 06/07/15, 11:52
Hmm, what is it that goes wrong in EXT:workspaces? -
Benni Mack updated the commit message in patch set 7 06/19/15, 13:51
-
Benni Mack voted on patch set 7 CR +1 V +1 06/19/15, 13:51
-
Markus Klein voted on patch set 7 CR +2 V +2 06/19/15, 20:47
-
Markus Klein merged patch set 7 06/19/15, 20:48
-
Markus Klein commented on patch set 8 06/19/15, 21:01
Functional tests broken. I'll revert -
Markus Klein commented on patch set 8 06/19/15, 21:01
Reverted This patchset was reverted in change: Ief8de9603ee1faf68f763c43b1cb48b72fa80ae1 -
Markus Klein commented on patch set 8 06/19/15, 21:04
re-pushed as https://review.typo3.org/40477