Review main Merged

40137[TASK] dbal: Ignore MySQL UNSIGNED/ZEROFILL in database schema compare

Morton Jonuschat CR +2 V +2 Normal +94 −0 updated 06/25/15, 22:29

Commit message

Avoid suggestions for database alterations in the install tool
that can not be implemented on DBMS other than MySQL due to
usage of non-standard attributes.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 7

  1. Morton Jonuschat uploaded patch set 1 06/09/15, 18:56

  2. Morton Jonuschat updated the commit message in patch set 2 06/19/15, 11:09

  3. Andreas Kienast commented on patch set 2 06/19/15, 11:19

    SqlSchemaMigrationService.php:292

    Wouldn't `trim(str_ireplace(array('UNSIGNED', 'ZEROFILL'), '', $fieldC));` be better?
  4. Morton Jonuschat commented on patch set 2 06/19/15, 11:31

    That would assume that UNSIGNED & ZEROFILL are the last part of the string. It wouldn't work on int(11) UNSIGNED NOT NULL DEFAUT '0' or something like that
  5. Andreas Kienast commented on patch set 2 CR +1 V +1 06/19/15, 11:50

    Verified by unit tests
  6. Christian Kuhn voted on patch set 2 CR +2 V +2 06/25/15, 22:29

  7. Christian Kuhn merged patch set 2 06/25/15, 22:29