Review main Merged

40204[BUGFIX] Empty item group in selectElement

Alexander Jahn CR +2 V +2 Easy +5 −0 updated 06/16/15, 10:51

Commit message

Item groups that do not have any items are ignored and not rendered

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Alexander Jahn +1
  • Verified V +2
    • Christian Kuhn +2
    • Pierrick Caillon +1
    • Alexander Jahn +1

Issues 1

Files 1

Review log 8

  1. Alexander Jahn uploaded patch set 1 06/12/15, 08:55

  2. Andreas Kienast commented on patch set 1 06/12/15, 09:19

    SelectSingleElement.php:219

    Please add a whitespace after "if". isset check is not necessary, because empty already calls isset() internally.
  3. Andreas Kienast uploaded patch set 2 06/12/15, 09:30

  4. Pierrick Caillon voted on patch set 2 V +1 06/15/15, 14:03

  5. Alexander Jahn voted on patch set 2 CR +1 V +1 06/16/15, 07:50

  6. Christian Kuhn commented on patch set 2 CR -1 06/16/15, 10:24

    working on it, will add an example to styleguide for this.
  7. Christian Kuhn commented on patch set 2 CR +2 V +2 06/16/15, 10:51

    select_15 of ext:styleguide shows this now.
  8. Christian Kuhn merged patch set 2 06/16/15, 10:51