Review main Merged

4022[TASK] Rename and deprecate config.minifyJS / config.minifyCSS

Xavier Perseguers CR +2 V +2 Normal +40 −21 updated 06/03/13, 20:49

Commit message

For consistency reasons, config.minifyJS should be renamed to config.compressJs
and config.minifyCSS should be renamed to config.compressCss.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 4

Review log 8

  1. Oliver Hader merged patch set 1 08/02/11, 13:04

  2. Stefan Neufeind commented on patch set 1 08/02/11, 13:04

    Looks good to me, but someone else must approve
  3. Steffen Kamper commented on patch set 1 08/02/11, 13:04

    Verified; Looks good to me, but someone else must approve
  4. Oliver Hader uploaded patch set 2 08/02/11, 13:04

  5. Oliver Hader commented on patch set 2 V 0 08/02/11, 13:04

    by team member; Looks good to me, approved There already have been some votes - together with mine it's fine
  6. Philipp Gampe commented on patch set 1 08/02/11, 13:04

    Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 08/02/11, 13:04

  8. Mr. Jenkins commented on patch set 2 08/02/11, 13:04