Review main Merged

4024[TASK] Fix CGL issues on class names in system extension form

Oliver Hader CR +2 V +2 Expert +885 −800 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Oliver Hader +2
    • Xavier Perseguers +1
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 262

Show 242 more files

Review log 9

  1. Björn Pedersen commented on patch set 1 09/19/11, 18:39

    (1 inline comment) Some files have an extra space (or CR+LF?) at all changed comment lines. Maybe that is causing the break?

    Common.php:42

    here all line have extra space ( could be also cr+LF? )
  2. Oliver Hader commented on patch set 1 09/19/11, 18:39

    Fails Does not work... however I don't know why...
  3. Oliver Hader uploaded patch set 2 09/19/11, 18:39

  4. Xavier Perseguers commented on patch set 2 09/19/11, 18:39

    Looks good to me, but someone else must approve 3 inline comments

    Container.php:99

    what about getLastPartOfClassName here?

    Container.php:98

    what about getLastPartOfClassName() here?

    Container.php:56

    what about getLastPart...?
  5. Georg Ringer commented on patch set 1 09/19/11, 18:39

    can also be Tx_ now
  6. Mr. Jenkins commented on patch set 1 09/19/11, 18:39

  7. Mr. Jenkins commented on patch set 2 09/19/11, 18:39

  8. Oliver Hader commented on patch set 2 V 0 09/19/11, 18:39

    by team member; Looks good to me, approved
  9. Oliver Hader merged patch set 2 09/19/11, 18:39