4024[TASK] Fix CGL issues on class names in system extension form
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Xavier Perseguers +1
-
Verified V +2
- Oliver Hader +2
Issues 1
Files 262
- typo3/sysext/form/Classes/Controller/Form.php+14 −14
- typo3/sysext/form/Classes/Controller/Wizard.php+15 −15
- typo3/sysext/form/Classes/Domain/Factory/JsonToTyposcript.php+1 −1
- typo3/sysext/form/Classes/Domain/Factory/Typoscript.php+10 −10
- typo3/sysext/form/Classes/Domain/Factory/TyposcriptToJson.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Additional/Abstract.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Additional/Additional.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Additional/Error.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Additional/Interface.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Additional/Label.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Additional/Legend.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Additional/Mandatory.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Abstract.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Accept.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Acceptcharset.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Accesskey.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Action.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Alt.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Attributes.php+6 −6
- typo3/sysext/form/Classes/Domain/Model/Attributes/Checked.php+1 −1
Show 242 more files
- typo3/sysext/form/Classes/Domain/Model/Attributes/Class.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Cols.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Dir.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Disabled.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Enctype.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Id.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Attributes/Interface.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Label.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Lang.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Maxlength.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Method.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Multiple.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Name.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Attributes/Readonly.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Rows.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Selected.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Size.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Src.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Style.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Tabindex.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Title.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Type.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attributes/Value.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Abstract.php+10 −10
- typo3/sysext/form/Classes/Domain/Model/Element/Button.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Element/Checkbox.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/Checkboxgroup.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Container.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Content.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Fieldset.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Fileupload.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Hidden.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/Imagebutton.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Optgroup.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/Option.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Element/Password.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/Radio.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/Radiogroup.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Reset.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Element/Select.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/Submit.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Element/Textarea.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Element/Textline.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Button.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Checkbox.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Checkboxgroup.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Container.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Element.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Fieldset.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Fileupload.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Form.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Header.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Hidden.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Name.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Password.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Radio.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Radiogroup.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Reset.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Select.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/JSON/Submit.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Textarea.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Textline.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Content.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Form.php+1 −1
- typo3/sysext/form/Classes/Domain/Repository/Content.php+9 −9
- typo3/sysext/form/Classes/Exception/General.php+2 −2
- typo3/sysext/form/Classes/Exception/Loader.php+2 −2
- typo3/sysext/form/Classes/System/Elementcounter/Elementcounter.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Alphabetic.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Alphanumeric.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Currency.php+3 −3
- typo3/sysext/form/Classes/System/Filter/Digit.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Filter.php+4 −4
- typo3/sysext/form/Classes/System/Filter/Integer.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Interface.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Lowercase.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Regexp.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Removexss.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Stripnewlines.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Titlecase.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Trim.php+2 −2
- typo3/sysext/form/Classes/System/Filter/Uppercase.php+1 −1
- typo3/sysext/form/Classes/System/Layout/Layout.php+3 −3
- typo3/sysext/form/Classes/System/Loader/Loader.php+2 −3
- typo3/sysext/form/Classes/System/Localization/Localization.php+1 −1
- typo3/sysext/form/Classes/System/Postprocessor/Mail.php+8 −8
- typo3/sysext/form/Classes/System/Postprocessor/Postprocessor.php+4 −4
- typo3/sysext/form/Classes/System/Request/Request.php+1 −1
- typo3/sysext/form/Classes/System/Validate/Abstract.php+5 −5
- typo3/sysext/form/Classes/System/Validate/Alphabetic.php+5 −5
- typo3/sysext/form/Classes/System/Validate/Alphanumeric.php+4 −4
- typo3/sysext/form/Classes/System/Validate/Between.php+3 −3
- typo3/sysext/form/Classes/System/Validate/Date.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Digit.php+3 −3
- typo3/sysext/form/Classes/System/Validate/Email.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Equals.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Fileallowedtypes.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Filemaximumsize.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Fileminimumsize.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Float.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Greaterthan.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Inarray.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Integer.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Interface.php+1 −1
- typo3/sysext/form/Classes/System/Validate/Ip.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Length.php+3 −3
- typo3/sysext/form/Classes/System/Validate/Lessthan.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Regexp.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Required.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Uri.php+2 −2
- typo3/sysext/form/Classes/System/Validate/Validate.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Additional/Additional.php+4 −3
- typo3/sysext/form/Classes/View/Confirmation/Additional/Label.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/Additional/Legend.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/Element/Abstract.php+35 −13
- typo3/sysext/form/Classes/View/Confirmation/Element/Checkbox.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Checkboxgroup.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Container.php1+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Fieldset.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Fileupload.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Optgroup.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Option.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Radio.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Radiogroup.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Select.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Textarea.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Element/Textline.php+3 −3
- typo3/sysext/form/Classes/View/Confirmation/Confirmation.php+7 −7
- typo3/sysext/form/Classes/View/Form/Additional/Additional.php+7 −3
- typo3/sysext/form/Classes/View/Form/Additional/Error.php+1 −1
- typo3/sysext/form/Classes/View/Form/Additional/Label.php+1 −1
- typo3/sysext/form/Classes/View/Form/Additional/Legend.php+1 −1
- typo3/sysext/form/Classes/View/Form/Additional/Mandatory.php+1 −1
- typo3/sysext/form/Classes/View/Form/Element/Abstract.php+25 −8
- typo3/sysext/form/Classes/View/Form/Element/Button.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Checkbox.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Checkboxgroup.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Container.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Content.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Fieldset.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Fileupload.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Hidden.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Imagebutton.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Optgroup.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Option.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Password.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Radio.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Radiogroup.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Reset.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Select.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Submit.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Textarea.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/Textline.php+3 −3
- typo3/sysext/form/Classes/View/Form/Form.php+4 −4
- typo3/sysext/form/Classes/View/Mail/Html/Additional/Additional.php+7 −3
- typo3/sysext/form/Classes/View/Mail/Html/Additional/Label.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Additional/Legend.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Element/Abstract.php+35 −13
- typo3/sysext/form/Classes/View/Mail/Html/Element/Checkbox.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Checkboxgroup.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Container.php1+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Fieldset.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Fileupload.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Hidden.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Optgroup.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Option.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Radio.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Radiogroup.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Select.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Textarea.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Element/Textline.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Html/Html.php+6 −6
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Abstract.phprenamed+18 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Checkbox.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Checkboxgroup.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Container.php1+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Fieldset.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Fileupload.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Hidden.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Optgroup.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Option.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Radio.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Radiogroup.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Select.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Textarea.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Textline.php+3 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Plain.php+2 −2
- typo3/sysext/form/Classes/View/Mail/Mail.php+3 −3
- typo3/sysext/form/Classes/View/Wizard/Load.php+3 −3
- typo3/sysext/form/Classes/View/Wizard/Save.php+3 −3
- typo3/sysext/form/Classes/View/Wizard/Wizard.php+3 −3
- typo3/sysext/form/Classes/Common.php1+1 −1
- typo3/sysext/form/Documentation/Tests/Attributes/button.txt+14 −14
- typo3/sysext/form/Documentation/Tests/Attributes/checkbox.txt+15 −15
- typo3/sysext/form/Documentation/Tests/Attributes/checkboxgroup.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Attributes/fieldset.txt+7 −8
- typo3/sysext/form/Documentation/Tests/Attributes/hidden.txt+5 −5
- typo3/sysext/form/Documentation/Tests/Attributes/imagebutton.txt+14 −14
- typo3/sysext/form/Documentation/Tests/Attributes/optgroup.txt+7 −7
- typo3/sysext/form/Documentation/Tests/Attributes/option.txt+10 −10
- typo3/sysext/form/Documentation/Tests/Attributes/password.txt+17 −17
- typo3/sysext/form/Documentation/Tests/Attributes/radio.txt+15 −15
- typo3/sysext/form/Documentation/Tests/Attributes/radiogroup.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Attributes/reset.txt+14 −14
- typo3/sysext/form/Documentation/Tests/Attributes/select.txt+12 −12
- typo3/sysext/form/Documentation/Tests/Attributes/submit.txt+14 −14
- typo3/sysext/form/Documentation/Tests/Attributes/textarea.txt+14 −14
- typo3/sysext/form/Documentation/Tests/Attributes/textline.txt+15 −15
- typo3/sysext/form/Documentation/Tests/Filter/alphabetic.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/alphanumeric.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/currency.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/digit.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/integer.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/lowercase.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/regexp.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/stripnewlines.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/titlecase.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/trim.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Filter/uppercase.txt+3 −3
- typo3/sysext/form/Documentation/Tests/Request/checkbox.txt+5 −5
- typo3/sysext/form/Documentation/Tests/Request/option.txt+7 −7
- typo3/sysext/form/Documentation/Tests/Request/radio.txt+5 −5
- typo3/sysext/form/Documentation/Tests/Validation/alphabetic.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/alphanumeric.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/between.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/combined.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/date.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/digit.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/email.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/equals.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/float.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/greaterthan.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/inarray.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/integer.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/ip.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/length.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/lessthan.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/regexp.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/required.txt+2 −2
- typo3/sysext/form/Documentation/Tests/Validation/uri.txt+2 −2
- typo3/sysext/form/ChangeLog+6 −6
- typo3/sysext/form/ext_autoload.php+2 −2
Review log 9
-
Björn Pedersen commented on patch set 1 09/19/11, 18:39
(1 inline comment) Some files have an extra space (or CR+LF?) at all changed comment lines. Maybe that is causing the break?Common.php:42here all line have extra space ( could be also cr+LF? ) -
Oliver Hader commented on patch set 1 09/19/11, 18:39
Fails Does not work... however I don't know why... -
Oliver Hader uploaded patch set 2 09/19/11, 18:39
-
Xavier Perseguers commented on patch set 2 09/19/11, 18:39
Looks good to me, but someone else must approve 3 inline commentsContainer.php:99what about getLastPartOfClassName here?Container.php:98what about getLastPartOfClassName() here?Container.php:56what about getLastPart...? -
Georg Ringer commented on patch set 1 09/19/11, 18:39
can also be Tx_ now -
Mr. Jenkins commented on patch set 1 09/19/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1553/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/19/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1898/ : SUCCESS -
Oliver Hader commented on patch set 2 V 0 09/19/11, 18:39
by team member; Looks good to me, approved -
Oliver Hader merged patch set 2 09/19/11, 18:39