40240[TASK] Cleanup for Package Management
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Helmut Hummel +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
- Helmut Hummel +1
Issues 1
Files 9
- typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php+9 −9
- typo3/sysext/core/Classes/Package/Exception/CorruptPackageException.phpdeleted+0 −23
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+1 −1
- typo3/sysext/core/Classes/Package/Package.php+3 −97
- typo3/sysext/core/Classes/Package/PackageInterface.php+5 −45
- typo3/sysext/core/Classes/Package/PackageManager.php+11 −28
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+7 −8
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+6 −32
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php1+0 −5
Review log 23
-
Benni Mack uploaded patch set 1 06/15/15, 09:06
-
Benni Mack uploaded patch set 2 06/17/15, 14:49
-
Helmut Hummel commented on patch set 2 V -1 06/23/15, 09:32
This completely breaks my installation. corrupts the package states file, extension installation breaks the system … no time to debug this now, but it seems there are some bits and pieces missing -
Helmut Hummel commented on patch set 2 06/23/15, 09:33
ListUtility.php:76I'm not sure if we have an issue here already, at least in mixed composer/non composer usage. -
Benni Mack uploaded patch set 3 07/06/15, 07:41
-
Benni Mack uploaded patch set 4 07/06/15, 08:45
-
Benni Mack commented on patch set 4 07/06/15, 08:52
Now the only thing that does not work are the unit tests that work with PATH_site instead of a protected variable now. -
Christian Kuhn commented on patch set 4 CR -1 07/07/15, 07:42
working on it. -
Christian Kuhn uploaded patch set 5 07/07/15, 08:31
-
Christian Kuhn commented on patch set 5 CR -1 07/07/15, 08:39
mmmh, there is still something wrong: tests fail, if only the Package tests are executed: TYPO3\CMS\Core\Tests\Unit\Package\PackageManagerTest::scanAvailablePackagesKeepsExistingPackageConfiguration TYPO3\CMS\Core\Tests\Unit\Package\PackageManagerTest::packageStatesConfigurationContainsRelativePaths Additionally, i know get a fatal running the whole suite: Fatal error: Uncaught exception 'BadFunctionCallException' with message 'TYPO3 Fatal Error: Extension key "extbase" is NOT loaded!' in /var/www/t3master/cms/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php:129 I assume there is still something wrong with the path stuff, but i can't figure out what exactly. Benni, could you have another look? -
Benni Mack uploaded patch set 6 07/08/15, 11:36
-
Markus Klein commented on patch set 6 V -1 07/08/15, 15:17
functional tests all broken -
Markus Klein commented on patch set 6 07/08/15, 15:19
-
Helmut Hummel uploaded patch set 7 07/08/15, 16:06
-
Helmut Hummel uploaded patch set 8 07/08/15, 16:12
-
Helmut Hummel uploaded patch set 9 07/08/15, 16:18
-
Helmut Hummel commented on patch set 9 CR +1 V +1 07/08/15, 16:20
looks good to me now -
Wouter Wolters voted on patch set 9 V +1 CR +1 07/08/15, 17:15
-
Markus Klein commented on patch set 9 CR -1 07/08/15, 17:16
Reviewing now -
Markus Klein voted on patch set 9 CR +1 V +1 07/08/15, 17:34
-
Markus Klein voted on patch set 9 CR +2 V +2 07/08/15, 17:43
-
Markus Klein merged patch set 9 07/08/15, 17:43
-
Christian Kuhn commented on patch set 9 07/08/15, 17:51
post +1. thank you!