Review main Merged

40241[TASK] Deprecate init.php

Benni Mack CR +2 V +2 Normal +124 −36 updated 06/17/15, 11:18

Commit message

In order to move all unneeded files from typo3/, the originally lengthy init.php
is now deprecated in favor of using the bootstrap initialization code directly in
the TYPO3 Backend.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 30

Review log 10

  1. Benni Mack uploaded patch set 1 06/15/15, 09:11

  2. Benni Mack uploaded patch set 2 06/15/15, 17:13

  3. Wouter Wolters commented on patch set 2 06/15/15, 17:45

    sysext/backend/Classes/FrontendBackendUserAuthentication.php 169: * Implementing the access checks that the typo3/init.php script does before a user is ever logged in. sysext/backend/Classes/Template/DocumentTemplate.php 36: * This file is typically included right after the init.php file, sysext/backend/Classes/AjaxLoginHandler.php 27: * the user inside the init.php part of the ajax call. If that was successful, we have sysext/core/Classes/Authentication/BackendUserAuthentication.php 2267: * This function is called right after ->start() in fx. init.php
  4. Wouter Wolters uploaded patch set 3 06/15/15, 19:04

  5. Wouter Wolters voted on patch set 3 V +1 CR +1 06/15/15, 19:23

  6. Helmut Hummel voted on patch set 3 CR +2 V +2 06/15/15, 19:52

  7. Helmut Hummel merged patch set 3 06/15/15, 19:52

  8. Markus Klein commented on patch set 4 06/17/15, 11:13

    Post -1 openid login not working anymore due to missing TYPO3_MODE. (ext_localconf files die)

    init.php:43

    Regression here. In case of openid the TYPO3_MODE is not defined anymore, since bootstrap does not do this.
  9. Wouter Wolters commented on patch set 4 06/17/15, 11:15

    db_new_content_el.php:23

    define('TYPO3_MODE', 'BE'); misses here

    class.tx_openid_return.php:20

    define('TYPO3_MODE', 'BE'); misses here
  10. Markus Klein commented on patch set 4 06/17/15, 11:18