40241[TASK] Deprecate init.php
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Wouter Wolters +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
Issues 1
Files 30
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+0 −2
- typo3/sysext/backend/Classes/Utility/IconUtility.php+0 −1
- typo3/sysext/backend/Classes/AjaxLoginHandler.php+1 −1
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+1 −1
- typo3/sysext/cms/layout/db_layout.php+5 −1
- typo3/sysext/cms/layout/db_new_content_el.php1+2 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+5 −5
- typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php+0 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-67471-InitPhp.rstnew+38 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −1
- typo3/sysext/openid/class.tx_openid_return.php1+2 −1
- typo3/alt_clickmenu.php+5 −2
- typo3/alt_db_navframe.php+4 −1
- typo3/alt_doc.php+4 −1
- typo3/alt_file_navframe.php+4 −1
- typo3/backend.php+4 −1
- typo3/browser.php+4 −1
- typo3/db_new.php+4 −1
Review log 10
-
Benni Mack uploaded patch set 1 06/15/15, 09:11
-
Benni Mack uploaded patch set 2 06/15/15, 17:13
-
Wouter Wolters commented on patch set 2 06/15/15, 17:45
sysext/backend/Classes/FrontendBackendUserAuthentication.php 169: * Implementing the access checks that the typo3/init.php script does before a user is ever logged in. sysext/backend/Classes/Template/DocumentTemplate.php 36: * This file is typically included right after the init.php file, sysext/backend/Classes/AjaxLoginHandler.php 27: * the user inside the init.php part of the ajax call. If that was successful, we have sysext/core/Classes/Authentication/BackendUserAuthentication.php 2267: * This function is called right after ->start() in fx. init.php -
Wouter Wolters uploaded patch set 3 06/15/15, 19:04
-
Wouter Wolters voted on patch set 3 V +1 CR +1 06/15/15, 19:23
-
Helmut Hummel voted on patch set 3 CR +2 V +2 06/15/15, 19:52
-
Helmut Hummel merged patch set 3 06/15/15, 19:52
-
Markus Klein commented on patch set 4 06/17/15, 11:13
Post -1 openid login not working anymore due to missing TYPO3_MODE. (ext_localconf files die)init.php:43Regression here. In case of openid the TYPO3_MODE is not defined anymore, since bootstrap does not do this. -
Wouter Wolters commented on patch set 4 06/17/15, 11:15
db_new_content_el.php:23define('TYPO3_MODE', 'BE'); misses hereclass.tx_openid_return.php:20define('TYPO3_MODE', 'BE'); misses here -
Markus Klein commented on patch set 4 06/17/15, 11:18
Followup in https://review.typo3.org/40342