Review main Merged

40251[BUGFIX] Always use MCRYPT_DEV_URANDOM if using mcrypt

Helmut Hummel CR +2 V +2 Easy +4 −6 updated 06/15/15, 16:22

Commit message

Using MCRYPT_RAND was introduced because of a bug in PHP versions lower
than 5.3.7 on Windows in combination with IIS.

Since we require higher PHP versions in all maintained versions we can
remove this workaround and use MCRYPT_DEV_URANDOM again. By doing so we
fix a bug on Windows caused by not enough randomness.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Nicole Hummel +1

Issues 1

Files 1

Review log 13

  1. Helmut Hummel uploaded patch set 1 06/15/15, 14:00

  2. Nicole Hummel voted on patch set 1 CR +1 V +1 06/15/15, 14:11

  3. Frank Nägler commented on patch set 1 06/15/15, 14:12

    GeneralUtility.php:1153

    Did we need the OS check here?
  4. Helmut Hummel uploaded patch set 2 06/15/15, 14:13

  5. Nicole Hummel commented on patch set 1 06/15/15, 14:14

    GeneralUtility.php:1153 Reply

    We have because you can't use openSsl encryption on Windows systems for performance reasons

    GeneralUtility.php:1155

    Please re-add the comment
  6. Nicole Hummel voted on patch set 2 CR +1 V +1 06/15/15, 14:15

  7. Frank Nägler commented on patch set 2 CR +1 06/15/15, 14:16

    ok, thanks
  8. Stephan Großberndt updated the commit message in patch set 3 06/15/15, 15:41

  9. Stephan Großberndt voted on patch set 3 CR +1 06/15/15, 15:41

  10. Nicole Hummel voted on patch set 3 CR +1 V +1 06/15/15, 15:54

  11. Helmut Hummel voted on patch set 3 CR +2 V +2 06/15/15, 16:21

  12. Wouter Wolters voted on patch set 3 V +1 CR +1 06/15/15, 16:22

  13. Helmut Hummel merged patch set 3 06/15/15, 16:22