Review main Merged

40256[BUGFIX] Scheduler now throws OutOfBoundsException on SQL query error

Mathias Schreiber CR +2 V +2 Easy +1 −1 updated 06/15/15, 17:21

Commit message

If the query for fetchTask fails for whatever reason, scheduler will
now gracefully throw an exception instead of assuming it had gotten
a valid resource pointer

Review

  • Code review CR +2
    • Benni Mack +2
    • Lienhart Woitok +1
    • Stephan Großberndt +1
  • Verified V +2
    • Benni Mack +2
    • Lienhart Woitok +1

Issues 2

Files 1

Review log 6

  1. Mathias Schreiber uploaded patch set 1 06/15/15, 16:00

  2. Lienhart Woitok voted on patch set 1 CR +1 V +1 06/15/15, 16:06

  3. Stephan Großberndt commented on patch set 1 CR +1 06/15/15, 16:13

    TYPO3\CMS\Scheduler\Controller\SchedulerCliController->loopTasks() causes the endless loop.
  4. Benni Mack voted on patch set 1 CR +2 V +2 06/15/15, 17:21

  5. Benni Mack merged patch set 1 06/15/15, 17:21

  6. Benni Mack commented on patch set 2 06/15/15, 17:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 35a096a8f717f2c52f15c98669d2301fa75c5f63