40260[BUGFIX] HSC the page title for MENU items
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 5
-
Benni Mack uploaded patch set 1 06/15/15, 16:34
-
Helmut Hummel commented on patch set 1 CR -1 06/15/15, 17:49
TextMenuContentObject.php:74I fear we can't do that. It might be the case that the menu is generated for JavaScript usage. It must be possible to disable hsc for such cases. -
Benni Mack commented on patch set 1 06/20/15, 20:05
TextMenuContentObject.php:74Replyso we should leave it like that then? One could still use stdWrap. encodeForJavaScriptValue = 1 and work with that, right? -
Helmut Hummel commented on patch set 1 06/23/15, 08:32
TextMenuContentObject.php:74Replywell at least I had no idea how to properly fix that with all the possiblities of TypoScript > One could still use stdWrap.encodeForJavaScriptValue = 1 yes, or stdWrap.htmlSpecialChars = 1 or stdWrap.stdWrap.htmlSpecialChars = 1 … we could set the config stdWrap.htmlSpecialChars = 1 by default if it is not set. then it would be like NO = 1 which could be skipped, as it is the default config -
Benni Mack abandoned the change 06/29/15, 22:08
OK. I have no clue how to fix it properly.
GraphicalMenuContentObject.php:388