40265[!!!][FEATURE] "Content-Language" HTTP header now added when rendering
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Frederic Gaus +1
- Jan Helke +1
-
Verified V +2
- Benni Mack +2
- Frederic Gaus +1
- Jan Helke +1
Issues 1
Files 2
Review log 17
-
Romain Leleu uploaded patch set 1 06/15/15, 17:59
-
Romain Leleu updated the commit message in patch set 2 06/15/15, 18:03
-
Mathias Brodala commented on patch set 2 CR -1 06/16/15, 06:56
Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.rst:8What option? ;-) -
Mathias Brodala commented on patch set 2 06/16/15, 06:57
I don't think this is breaking. -
Andreas Kienast commented on patch set 2 06/16/15, 08:13
This change is indeed not breaking, as the new config is a opt-in. -
Mathias Schreiber commented on patch set 2 06/16/15, 08:16
It IS breaking, since the default behavior changes. The lang header is being sent and you can DISABLE it with the new config option. I will talk to Romain about the documentation stuff. -
Andreas Kienast commented on patch set 2 06/16/15, 08:42
My point is that this option is not enabled by default, so it's not a breaking change to me. -
Andreas Kienast commented on patch set 2 06/16/15, 08:46
Thanks to Mattes now I get why it's breaking - the header is now sent by default. The old behaviour is recovered if you enable the new option. -
Romain Leleu uploaded patch set 3 06/16/15, 08:54
-
Benni Mack voted on patch set 3 CR +1 V +1 06/16/15, 14:50
-
Benni Mack uploaded patch set 4 06/16/15, 14:59
-
Benni Mack voted on patch set 4 CR +1 V +1 06/16/15, 15:09
-
Jan Helke voted on patch set 4 CR +1 06/16/15, 15:12
-
Jan Helke voted on patch set 4 V +1 06/16/15, 15:24
-
Frederic Gaus voted on patch set 4 CR +1 V +1 06/16/15, 15:42
-
Benni Mack voted on patch set 4 CR +2 V +2 06/16/15, 16:02
-
Benni Mack merged patch set 4 06/16/15, 16:02
Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.rst:8