Review main Merged Breaking

40265[!!!][FEATURE] "Content-Language" HTTP header now added when rendering

Romain Leleu CR +2 V +2 Easy +22 −0 updated 11/25/16, 10:56

Commit message

The "Content-Language" is now sent as a both meta tag and HTTP header.
Previously page language information was only sent as meta tag.

By default new and existing installations will send a header
"Content-language: XX" where "XX" is the iso code of the
sys_language_content if that is properly defined by the sys_language
record representing the sys_language_uid.
A new Typoscript configuration "config.disableLanguageHeader" allows
to disable this behavior.
You must set "config.disableLanguageHeader" to get the previous
behavior (no header).

Review

  • Code review CR +2
    • Benni Mack +2
    • Frederic Gaus +1
    • Jan Helke +1
  • Verified V +2
    • Benni Mack +2
    • Frederic Gaus +1
    • Jan Helke +1

Issues 1

Files 2

Review log 17

  1. Romain Leleu uploaded patch set 1 06/15/15, 17:59

  2. Romain Leleu updated the commit message in patch set 2 06/15/15, 18:03

  3. Mathias Brodala commented on patch set 2 CR -1 06/16/15, 06:56

    Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.rst:8

    Please clarify what "XX" means.

    Feature-33071-AddTheHttpHeaderContent-LanguageWhenRenderingAPage.rst:8

    What option? ;-)
  4. Mathias Brodala commented on patch set 2 06/16/15, 06:57

    I don't think this is breaking.
  5. Andreas Kienast commented on patch set 2 06/16/15, 08:13

    This change is indeed not breaking, as the new config is a opt-in.
  6. Mathias Schreiber commented on patch set 2 06/16/15, 08:16

    It IS breaking, since the default behavior changes. The lang header is being sent and you can DISABLE it with the new config option. I will talk to Romain about the documentation stuff.
  7. Andreas Kienast commented on patch set 2 06/16/15, 08:42

    My point is that this option is not enabled by default, so it's not a breaking change to me.
  8. Andreas Kienast commented on patch set 2 06/16/15, 08:46

    Thanks to Mattes now I get why it's breaking - the header is now sent by default. The old behaviour is recovered if you enable the new option.
  9. Romain Leleu uploaded patch set 3 06/16/15, 08:54

  10. Benni Mack voted on patch set 3 CR +1 V +1 06/16/15, 14:50

  11. Benni Mack uploaded patch set 4 06/16/15, 14:59

  12. Benni Mack voted on patch set 4 CR +1 V +1 06/16/15, 15:09

  13. Jan Helke voted on patch set 4 CR +1 06/16/15, 15:12

  14. Jan Helke voted on patch set 4 V +1 06/16/15, 15:24

  15. Frederic Gaus voted on patch set 4 CR +1 V +1 06/16/15, 15:42

  16. Benni Mack voted on patch set 4 CR +2 V +2 06/16/15, 16:02

  17. Benni Mack merged patch set 4 06/16/15, 16:02