Review main Merged

40287[BUGFIX] 404 error after closing edit wizard

Gilles Fouet CR +2 V +2 Easy +1 −1 updated 06/16/15, 14:32

Commit message

The returnUrl parameter was double encoded around getModuleUrl.
Now it's encoded only one time.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Daniel Maier +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Daniel Maier +1

Issues 1

Files 1

Review log 12

  1. Gilles Fouet uploaded patch set 1 06/16/15, 10:47

  2. Gilles Fouet updated the commit message in patch set 2 06/16/15, 10:54

  3. Daniel Maier commented on patch set 2 V -1 06/16/15, 11:09

    When clicking on "Create new group" next to the "edit usergroup" now, there returnUrl seems not to be overgiven correctly there any more. After closing the following form, I get the following error: "The CSRF protection token for the requested module is missing or invalid". Can you please check that? Thanks.
  4. Wouter Wolters commented on patch set 2 06/16/15, 11:21

    The problem is double encoding. The returnUrl in this popup should be encoded once.
  5. Wouter Wolters voted on patch set 2 V -1 CR -1 06/16/15, 11:21

  6. Wouter Wolters commented on patch set 2 06/16/15, 11:29

    Posted the solution on Slack to Gilles
  7. Gilles Fouet uploaded patch set 3 06/16/15, 14:20

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 06/16/15, 14:21

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 06/16/15, 14:31

  10. Daniel Maier voted on patch set 3 CR +1 V +1 06/16/15, 14:32

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 06/16/15, 14:32

  12. Christian Kuhn merged patch set 3 06/16/15, 14:32