Review main Abandoned

40304[TASK] Validate emails in SystemStatusUpdate task

Wouter Wolters CR 0 V 0 Easy +9 −1 updated 06/16/15, 17:10

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 5

  1. Wouter Wolters uploaded patch set 1 06/16/15, 14:32

  2. Wouter Wolters commented on patch set 1 CR -1 06/16/15, 14:36

    wait a second here, updating incoming
  3. Wouter Wolters uploaded patch set 2 06/16/15, 14:37

  4. Christian Kuhn commented on patch set 2 06/16/15, 17:06

    how to reproduce? the data provider forbids storing of invalid addresses already, so saving a "broken" record seems impossible.
  5. Wouter Wolters abandoned the change 06/16/15, 17:10

    hmm I missed that somehow. I did another patch in this area and saw this difference, so implemented the same check here. But the provider already validates the user input correctly. So I abandon this one.