Review main Merged

40305[TASK] Deprecate IconUtility::getIcon and clean up "gfx/i/"

Benni Mack CR +2 V +2 Easy +34 −5 updated 06/16/15, 15:53

Commit message

The method IconUtility::getIcon was used for returning
overlaid icons before TYPO3 CMS 4.4, based on raw icons
inside gfx/i/ and created temporary icons when not present.

The left-over function calls are replaced with sprite icon calls.

Additionally, in order to thin out typo3/gfx/, all icons which have
always been overlaid with t3skin already have been removed. All
other files from typo3/gfx/i/ are moved to EXT:t3skin to
stay compatible.

With TYPO3 CMS 8, the folder EXT:t3skin/icons/gfx/i/ will
be completely removed with the function itself.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frederic Gaus +1
    • Jan Helke +1
  • Verified V +2
    • Wouter Wolters +2
    • Frederic Gaus +1
    • Jan Helke +1

Issues 1

Files 390

Show 370 more files

Review log 5

  1. Benni Mack uploaded patch set 1 06/16/15, 14:32

  2. Jan Helke voted on patch set 1 CR +1 V +1 06/16/15, 15:02

  3. Frederic Gaus voted on patch set 1 CR +1 V +1 06/16/15, 15:47

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 06/16/15, 15:53

  5. Wouter Wolters merged patch set 1 06/16/15, 15:53