Review main Merged

40321[BUGFIX] Properly escape option value for groups

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 06/17/15, 18:40

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 6

  1. Wouter Wolters uploaded patch set 1 06/16/15, 17:19

  2. Stephan Großberndt commented on patch set 1 06/16/15, 17:28

    Class is the key from '$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']' filled in SchedulerModuleController->getRegisteredClasses(). Being able to insert something in there requires php access and then all kind of other havoc could be done anyway?
  3. Helmut Hummel commented on patch set 1 06/16/15, 18:14

    > Being able to insert something in there requires php access and then all kind of other havoc could be done anyway We're outputting something into HTML context. No matter where this something comes from, it needs to be HTML encoded. Easy as that. Stick to this practice and you never need to think about where this value comes from or even worse waste time to look it up …
  4. Helmut Hummel voted on patch set 1 CR +2 V +2 06/16/15, 18:14

  5. Stephan Großberndt voted on patch set 1 CR +1 06/16/15, 18:22

  6. Helmut Hummel merged patch set 1 06/17/15, 18:40