Review main Merged

40328[BUGFIX] Properly escape data in PermissionAjaxController

Wouter Wolters CR +2 V +2 Easy +12 −4 updated 06/20/15, 16:36

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 1

Review log 11

  1. Wouter Wolters uploaded patch set 1 06/16/15, 19:40

  2. Helmut Hummel voted on patch set 1 CR +2 V +2 06/17/15, 18:41

  3. Markus Klein commented on patch set 1 CR -1 06/17/15, 20:53

    PermissionAjaxController.php:168

    both parameter should be casted to int

    PermissionAjaxController.php:183

    then we don't need any of those hsc()
  4. Wouter Wolters uploaded patch set 2 06/18/15, 08:21

  5. Wouter Wolters uploaded patch set 3 06/18/15, 08:22

  6. Andreas Kienast commented on patch set 3 06/18/15, 08:44

    PermissionAjaxController.php:178

    Can't you cast $uid to an int and drop the hsc() here?

    PermissionAjaxController.php:214

    same here
  7. Markus Klein voted on patch set 3 CR +1 V +1 06/18/15, 21:37

  8. Wouter Wolters uploaded patch set 4 06/20/15, 14:58

  9. Markus Klein voted on patch set 4 V +1 CR +1 06/20/15, 16:20

  10. Benni Mack voted on patch set 4 CR +2 V +2 06/20/15, 16:36

  11. Benni Mack merged patch set 4 06/20/15, 16:36