Review main Merged

40334[TASK] Use GeneralUtility::quoteJSvalue() where needed part 3

Wouter Wolters CR +2 V +2 Easy +30 −13 updated 06/23/15, 20:34

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 7

Review log 16

  1. Wouter Wolters uploaded patch set 1 06/17/15, 07:59

  2. Markus Klein commented on patch set 1 06/17/15, 08:07

    ContentObjectRenderer.php:1732

    () superfluous. please split that into multiline

    AbstractMenuContentObject.php:1597

    () too much

    AbstractPlugin.php:470

    one () pair superfluous

    AbstractPlugin.php:470

    same here

    AdminPanelView.php:442

    () not needed md5() needs no quoting for JS IMHO
  3. Helmut Hummel commented on patch set 1 06/17/15, 18:44

    AdminPanelView.php:442 Reply

    I agree on the md5 …
  4. Wouter Wolters uploaded patch set 2 06/17/15, 19:30

  5. Markus Klein commented on patch set 2 06/17/15, 19:49

    will push an update

    ContentObjectRenderer.php:1734

    neither of these two needs quoteJs

    AbstractMenuContentObject.php:1598

    same here

    AbstractPlugin.php:470

    one set () superfluous

    AbstractPlugin.php:472

    ?:
  6. Markus Klein uploaded patch set 3 06/17/15, 19:56

  7. Markus Klein voted on patch set 3 CR +1 V +1 06/17/15, 19:56

  8. Nicole Hummel commented on patch set 3 CR -1 06/18/15, 11:20

    GraphicalMenuContentObject.php:422

    Should we add another quoteJSvalue here as well?

    GraphicalMenuContentObject.php:423

    And here?

    TranslationStatusController.php:198

    The variable was quoted before and should be quoted here as well.

    AbstractPlugin.php:472

    not needed here

    AdminPanelView.php:442

    Remove double brackets
  9. Markus Klein commented on patch set 3 06/18/15, 11:40

    AbstractPlugin.php:472 Reply

    we don't know what $winName might contain
  10. Nicole Hummel commented on patch set 3 06/18/15, 11:54

    AbstractPlugin.php:472 Reply

    Ah, sorry. Mixed up that ?:
  11. Markus Klein commented on patch set 3 06/18/15, 19:40

    GraphicalMenuContentObject.php:422 Reply

    Done

    GraphicalMenuContentObject.php:423 Reply

    Done

    TranslationStatusController.php:198 Reply

    Done

    AdminPanelView.php:442 Reply

    Done
  12. Markus Klein uploaded patch set 4 06/18/15, 19:41

  13. Markus Klein voted on patch set 4 CR +1 V +1 06/18/15, 19:41

  14. Nicole Hummel voted on patch set 4 CR +1 06/19/15, 08:35

  15. Christian Kuhn commented on patch set 4 CR +2 V +2 06/23/15, 20:34

    The patch reads fine and i was unable to find a gotcha. Lets get this in quickly in 7.4 cycle to have it in for a long time in case we missed something. ...
  16. Christian Kuhn merged patch set 4 06/23/15, 20:34