40334[TASK] Use GeneralUtility::quoteJSvalue() where needed part 3
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 7
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php2+5 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/GraphicalMenuContentObject.php4+4 −4
- typo3/sysext/frontend/Classes/ContentObject/Menu/JavaScriptMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+8 −2
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php2+5 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php7+5 −1
- typo3/sysext/frontend/Classes/View/AdminPanelView.php4+2 −2
Review log 16
-
Wouter Wolters uploaded patch set 1 06/17/15, 07:59
-
Markus Klein commented on patch set 1 06/17/15, 08:07
AbstractMenuContentObject.php:1597() too muchAbstractPlugin.php:470one () pair superfluousAbstractPlugin.php:470same hereAdminPanelView.php:442() not needed md5() needs no quoting for JS IMHO -
Helmut Hummel commented on patch set 1 06/17/15, 18:44
AdminPanelView.php:442ReplyI agree on the md5 … -
Wouter Wolters uploaded patch set 2 06/17/15, 19:30
-
Markus Klein commented on patch set 2 06/17/15, 19:49
will push an updateContentObjectRenderer.php:1734neither of these two needs quoteJsAbstractMenuContentObject.php:1598same hereAbstractPlugin.php:470one set () superfluousAbstractPlugin.php:472?: -
Markus Klein uploaded patch set 3 06/17/15, 19:56
-
Markus Klein voted on patch set 3 CR +1 V +1 06/17/15, 19:56
-
Nicole Hummel commented on patch set 3 CR -1 06/18/15, 11:20
GraphicalMenuContentObject.php:422Should we add another quoteJSvalue here as well?GraphicalMenuContentObject.php:423And here?TranslationStatusController.php:198The variable was quoted before and should be quoted here as well.AbstractPlugin.php:472not needed hereAdminPanelView.php:442Remove double brackets -
Markus Klein commented on patch set 3 06/18/15, 11:40
AbstractPlugin.php:472Replywe don't know what $winName might contain -
Nicole Hummel commented on patch set 3 06/18/15, 11:54
AbstractPlugin.php:472ReplyAh, sorry. Mixed up that ?: -
Markus Klein commented on patch set 3 06/18/15, 19:40
GraphicalMenuContentObject.php:422ReplyDoneGraphicalMenuContentObject.php:423ReplyDoneTranslationStatusController.php:198ReplyDoneAdminPanelView.php:442ReplyDone -
Markus Klein uploaded patch set 4 06/18/15, 19:41
-
Markus Klein voted on patch set 4 CR +1 V +1 06/18/15, 19:41
-
Nicole Hummel voted on patch set 4 CR +1 06/19/15, 08:35
-
Christian Kuhn commented on patch set 4 CR +2 V +2 06/23/15, 20:34
The patch reads fine and i was unable to find a gotcha. Lets get this in quickly in 7.4 cycle to have it in for a long time in case we missed something. ... -
Christian Kuhn merged patch set 4 06/23/15, 20:34
ContentObjectRenderer.php:1732