Review main Merged

40362[TASK] Convert dropdowns in clipboard to TWBS

Jan Helke CR +2 V +2 Normal +43 −20 updated 06/17/15, 18:03

Commit message

This patch converts the dropdowns in the clipboard from select options to
ul li list to follow the TWBS guidelines.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Alina Fleser +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Wolf +2
    • Alina Fleser +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 11

  1. Jan Helke uploaded patch set 1 06/17/15, 13:57

  2. Andreas Wolf voted on patch set 1 CR +1 V +1 06/17/15, 14:40

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/17/15, 17:02

  4. Alina Fleser commented on patch set 1 06/17/15, 17:02

    Can you use lowerCamelCase for $copymode_selector, $selector_menu, maibe also change the name of $rmall_url?
  5. Christian Kuhn voted on patch set 1 CR 0 V 0 06/17/15, 17:02

  6. Jan Helke voted on patch set 1 CR -1 06/17/15, 17:05

  7. Jan Helke uploaded patch set 2 06/17/15, 17:15

  8. Christian Kuhn commented on patch set 2 CR +1 V +1 06/17/15, 17:24

    waiting for vote from alina before merge.
  9. Andreas Wolf voted on patch set 2 CR +2 V +2 06/17/15, 17:32

  10. Alina Fleser voted on patch set 2 CR +1 V +1 06/17/15, 17:45

  11. Andreas Wolf merged patch set 2 06/17/15, 18:03