Review main Merged Breaking

40367[!!!][TASK] Remove deprecated function calls since 6.2

Benni Mack CR +2 V +2 Normal +32 −65 updated 06/18/15, 21:56

Commit message

Some last leftover deprecated methods and logic are removed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 6

Review log 18

  1. Benni Mack uploaded patch set 1 06/17/15, 15:07

  2. Andreas Kienast commented on patch set 1 CR -1 06/17/15, 16:48

    AjaxRequestHandler.php:79

    &&
  3. Andreas Kienast commented on patch set 1 06/17/15, 16:49

    Breaking-67565-DeprecatedBackendRelatedMethodsRemoved.rst:2

    Spaces are missing :)
  4. Andreas Kienast uploaded patch set 2 06/17/15, 17:00

  5. Andreas Kienast voted on patch set 2 CR +1 06/17/15, 17:01

  6. Markus Klein updated the commit message in patch set 3 06/17/15, 19:39

  7. Markus Klein commented on patch set 3 06/17/15, 19:43

    Breaking-67565-DeprecatedBackendRelatedMethodsRemoved.rst:13

    space
  8. Andreas Kienast uploaded patch set 4 06/17/15, 19:46

  9. Andreas Kienast voted on patch set 4 CR +1 06/17/15, 19:46

  10. Markus Klein commented on patch set 4 06/17/15, 20:03

    AjaxRequestHandler.php:79

    one more thought: should be bail out with an exception if the configuration does not comply to our expectations? (we do that with all newer APIs now)

    ModuleMenuView.php:24

    ?? used in typo3/sysext/backend/Classes/Module/ModuleController.php:54
  11. Markus Klein commented on patch set 4 CR -1 V -1 06/17/15, 20:07

    will update
  12. Markus Klein commented on patch set 4 06/17/15, 20:10

    AjaxRequestHandler.php:79 Reply

    this is done below.
  13. Markus Klein uploaded patch set 5 06/17/15, 20:11

  14. Markus Klein voted on patch set 5 CR +1 V +1 06/17/15, 20:11

  15. Wouter Wolters updated the commit message in patch set 6 06/18/15, 21:55

  16. Markus Klein voted on patch set 6 CR +1 V +1 06/18/15, 21:55

  17. Wouter Wolters voted on patch set 6 V +2 CR +2 06/18/15, 21:56

  18. Wouter Wolters merged patch set 6 06/18/15, 21:56