40430[BUGFIX] VariableContainer should be available in getLayoutName
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Andreas Kienast +1
- Jigal van Hemert +1
- Christian Müller +1
- Philipp Wrann +1
-
Verified V +2
- Helmut Hummel +2
- Jigal van Hemert +1
Issues 1
Files 1
Review log 13
-
Christian Müller uploaded patch set 1 06/18/15, 10:11
-
Mathias Brodala commented on patch set 1 CR +1 06/18/15, 10:17
Cannot verify without unit test. -
Andreas Kienast updated the commit message in patch set 2 06/18/15, 10:22
-
Andreas Kienast voted on patch set 2 CR +1 06/18/15, 10:23
-
Christian Müller voted on patch set 2 CR +1 06/18/15, 10:36
-
Christian Müller commented on patch set 2 06/18/15, 10:37
@Mathias, this code is put into the caches Fluid templates, not even sure if we can have a unit test for that. -
Mathias Brodala commented on patch set 2 06/18/15, 10:46
Not as unit test (that'd only check the string to be stored in the cache) but maybe as functional test. If someone is able to add one, this would be nice to have but it's not a blocker. -
Helmut Hummel voted on patch set 2 CR +1 06/18/15, 11:53
-
Philipp Wrann voted on patch set 2 CR +1 06/18/15, 13:51
-
Jigal van Hemert commented on patch set 2 V +1 CR +1 06/22/15, 19:23
Works as advertised. -
Helmut Hummel voted on patch set 2 CR +2 V +2 06/22/15, 19:24
-
Helmut Hummel merged patch set 2 06/22/15, 19:25
-
Helmut Hummel commented on patch set 3 06/22/15, 19:27
Cherry Picked This patchset was cherry picked to branch TYPO3_7-3 as commit 1f9e0fc22bc7bcd4145822ef8b612570ea3281a1