Review main Merged

40436[BUGFIX] Use single quotes for password check

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 06/18/15, 11:01

Commit message

Use single quotes for the password check in
SaltedPasswordsUtility::getNumberOfBackendUsersWithInsecurePassword
to tell other DBMS to expect a value and not an identifier.

Using double quotes for values violates the SQL standard.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 6

  1. Andreas Kienast uploaded patch set 1 06/18/15, 10:46

  2. Markus Klein updated the commit message in patch set 2 06/18/15, 10:49

  3. Markus Klein voted on patch set 2 CR +2 V +2 06/18/15, 10:49

  4. Stephan Großberndt voted on patch set 2 CR +1 06/18/15, 10:49

  5. Markus Klein merged patch set 2 06/18/15, 11:01

  6. Markus Klein commented on patch set 3 06/18/15, 11:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c4aef6ce6e66374f18cd51ea8ee61208b17b47af