40457[CLEANUP] Replace create_function() with closure
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Andreas Kienast +1
-
Verified V +2
- Wouter Wolters +2
- Andreas Kienast +1
Issues 1
Files 5
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php3+1 −20
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.phpbinary
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+4 −4
Review log 9
-
Markus Klein uploaded patch set 1 06/18/15, 21:53
-
Markus Klein commented on patch set 1 06/18/15, 21:55
There is one more call left, which will be fixed with https://review.typo3.org/40176 -
Andreas Kienast uploaded patch set 2 06/19/15, 05:03
-
Andreas Kienast voted on patch set 2 CR +1 V +1 06/19/15, 05:03
-
Andreas Kienast commented on patch set 2 06/19/15, 05:04
ArrayUtilityTest.php:1871Why is this test removed? -
Wouter Wolters commented on patch set 2 06/19/15, 06:46
ArrayUtilityTest.php:1871ReplySee test below, create_function is discouraged and a closure test is already in place -
Wouter Wolters voted on patch set 2 V +2 CR +2 06/19/15, 06:49
-
Andreas Kienast commented on patch set 2 06/19/15, 07:00
ArrayUtilityTest.php:1871ReplyOf course... I didn't have coffee, sorry -
Wouter Wolters merged patch set 2 06/19/15, 07:04