Review main Merged

40457[CLEANUP] Replace create_function() with closure

Markus Klein CR +2 V +2 Easy +7 −26 updated 06/19/15, 07:04

Commit message

The create_function() function is discouraged due to internal usage
of eval(). Replace all calls with a real closure, which is supported
since PHP 5.3.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 5

Review log 9

  1. Markus Klein uploaded patch set 1 06/18/15, 21:53

  2. Markus Klein commented on patch set 1 06/18/15, 21:55

    There is one more call left, which will be fixed with https://review.typo3.org/40176
  3. Andreas Kienast uploaded patch set 2 06/19/15, 05:03

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 06/19/15, 05:03

  5. Andreas Kienast commented on patch set 2 06/19/15, 05:04

    ArrayUtilityTest.php:1871

    Why is this test removed?
  6. Wouter Wolters commented on patch set 2 06/19/15, 06:46

    ArrayUtilityTest.php:1871 Reply

    See test below, create_function is discouraged and a closure test is already in place
  7. Wouter Wolters voted on patch set 2 V +2 CR +2 06/19/15, 06:49

  8. Andreas Kienast commented on patch set 2 06/19/15, 07:00

    ArrayUtilityTest.php:1871 Reply

    Of course... I didn't have coffee, sorry
  9. Wouter Wolters merged patch set 2 06/19/15, 07:04