Review main Merged

40466[BUGFIX] EXT:reports does not recognize TYPO3 CMS 7.3.0 as released

Xavier Perseguers CR +2 V +2 Hard +157 −219 updated 06/24/15, 10:19

Commit message

Since the versioning scheme for TYPO3 CMS branches has changed with the
kickstart of TYPO3 CMS 7 LTS development, the structure of the JSON feed
http://get.typo3.org/json has been adapted accordingly and needs to be
taken into account in EXT:reports.

Read more:
https://typo3.org/teams/core-development-team/resources/release-lifecycle/

Review

  • Code review CR +2
    • Benni Mack +2
    • Frederic Gaus +1
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Frederic Gaus +1
    • Markus Klein +1
    • Michael Schams +1

Issues 1

Files 3

Review log 19

  1. Xavier Perseguers uploaded patch set 1 06/19/15, 11:39

  2. Xavier Perseguers commented on patch set 1 CR -1 06/19/15, 11:40

    Unit tests need to be adapted but currently heavily rely on testing internal (now changed) methods, thus the WIP at the moment.
  3. Xavier Perseguers uploaded patch set 2 06/19/15, 12:23

  4. Xavier Perseguers commented on patch set 2 06/19/15, 12:25

    CoreVersionService.php:322

    Although message was slightly changed, this is still "the same error"
  5. Michael Schams commented on patch set 2 V +1 06/19/15, 12:31

    version 7.3.0 is a valid version in EXT:reports now.
  6. Markus Klein uploaded patch set 3 06/19/15, 12:41

  7. Markus Klein commented on patch set 3 CR -1 06/19/15, 12:44

    I'm sorry, seems we've been working on the same thing. I'll incorporate your changes!
  8. Xavier Perseguers commented on patch set 3 06/19/15, 12:45

    CoreVersionService.php:71

    This does not work and will require an update when 8 comes out, do we really want that?
  9. Markus Klein uploaded patch set 4 06/19/15, 12:55

  10. Markus Klein commented on patch set 3 06/19/15, 13:02

    CoreVersionService.php:71 Reply

    just an idea.
  11. Markus Klein uploaded patch set 5 06/19/15, 13:12

  12. Michael Schams voted on patch set 5 V +1 06/20/15, 00:52

  13. Markus Klein voted on patch set 5 CR +1 V +1 06/20/15, 11:00

  14. Benni Mack voted on patch set 5 V +2 06/20/15, 12:40

  15. Frederic Gaus voted on patch set 5 CR +1 06/22/15, 10:05

  16. Frederic Gaus voted on patch set 5 V +1 06/22/15, 10:05

  17. Benni Mack voted on patch set 5 CR +2 06/22/15, 10:28

  18. Benni Mack merged patch set 5 06/22/15, 10:28

  19. Christian Kuhn commented on patch set 6 06/24/15, 10:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-3 as commit 1f54c11004ca517bb0c5eddf7378ad49c5db8924