40477[BUGFIX] Change default label for sys_file_references
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Oliver Hader +1
-
Verified V +2
- Alexander Opitz +2
- Oliver Hader +1
Issues 1
Files 3
Review log 23
-
Markus Klein uploaded patch set 1 06/19/15, 21:04
-
Markus Klein commented on patch set 1 CR -1 V -1 06/19/15, 21:04
functional tests still broken -
Daniel Goerz commented on patch set 1 07/26/15, 12:16
If I apply the three changes by Hand the tests are fine. If I cherry-pick the patch, they fail. Failing tests are in workspace sysext btw. -
Benni Mack wrote 08/12/15, 20:21
Topic set to FAL -
Oliver Hader uploaded patch set 2 10/09/15, 06:30
-
Nicole Hummel commented on patch set 2 V -1 10/13/15, 10:23
There were 12 failures: 1) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest::copyContent Record "sys_file_reference:130" not found in database Record "sys_file_reference:131" not found in database Record "sys_file_reference:132" not found in database Record "sys_file_reference:133" not found in database Assertion in data-set failed for "tt_content:333": Fields|Assertion|Record image |2 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest.php:71 2) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest::localizeContent Record "sys_file_reference:130" not found in database Record "sys_file_reference:131" not found in database Record "sys_file_reference:132" not found in database Record "sys_file_reference:133" not found in database Assertion in data-set failed for "tt_content:333": Fields|Assertion|Record image |2 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest.php:88 3) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest::createContentWithFileReference Record "sys_file_reference:130" not found in database Record "sys_file_reference:131" not found in database Assertion in data-set failed for "tt_content:333": Fields|Assertion|Record image |1 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest.php:177 4) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest::modifyContentAndAddFileReference Record "sys_file_reference:132" not found in database Record "sys_file_reference:133" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |3 |2 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Modify\ActionTest.php:211 5) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest::copyContent Record "sys_file_reference:130" not found in database Record "sys_file_reference:132" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |2 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest.php:74 6) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest::localizeContent Record "sys_file_reference:130" not found in database Record "sys_file_reference:132" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |2 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest.php:92 7) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest::createContentWithFileReference Record "sys_file_reference:130" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |1 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest.php:184 8) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest::modifyContentAndAddFileReference Record "sys_file_reference:132" not found in database Assertion in data-set failed for "tt_content:331": Fields|Assertion|Record image |3 |2 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\PublishAll\ActionTest.php:220 9) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest::copyContent Record "sys_file_reference:130" not found in database Record "sys_file_reference:132" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |2 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest.php:74 10) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest::localizeContent Record "sys_file_reference:130" not found in database Record "sys_file_reference:132" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |2 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest.php:92 11) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest::createContentWithFileReference Record "sys_file_reference:130" not found in database Assertion in data-set failed for "tt_content:332": Fields|Assertion|Record image |1 |0 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest.php:188 12) TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest::modifyContentAndAddFileReference Record "sys_file_reference:132" not found in database Assertion in data-set failed for "tt_content:331": Fields|Assertion|Record image |3 |2 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase.php:172 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\workspaces\Tests\Functional\DataHandling\FAL\Publish\ActionTest.php:224 -
Morton Jonuschat commented on patch set 2 10/16/15, 19:51
Tests fail with SQL errors "Incorrect integer value: '[PLACEHOLDER, WS#1]' for column 'uid_local' at row 1" The workspace module seems to try and replace the title... -
Stefan Neufeind commented on patch set 2 10/18/15, 15:59
@Markus: Could you look into the tests again, please? -
Markus Klein commented on patch set 2 10/18/15, 16:55
I have no clue about this one, I didn't create the patch. I just repushed it after revert! -
Stephan Großberndt commented on patch set 2 10/18/15, 16:57
Original patch was https://review.typo3.org/#/c/39964/ -
Stephan Großberndt uploaded patch set 3 10/20/15, 19:19
-
Stephan Großberndt uploaded patch set 4 10/20/15, 19:20
-
Stephan Großberndt uploaded patch set 5 10/20/15, 19:31
-
Stephan Großberndt commented on patch set 5 10/20/15, 19:32
Accidentally pushed with the wrong change-id. Restored patch set 2. -
Markus Klein commented on patch set 5 CR -1 10/20/15, 19:44
still not working I guess ^^ -
Stephan Großberndt commented on patch set 5 10/20/15, 19:46
Right. I wanted to look into this but got a failing test on windows. This is fixed with https://review.typo3.org/#/c/44187/ Will look into this now. -
Oliver Hader uploaded patch set 6 10/29/15, 10:48
-
Stephan Großberndt commented on patch set 6 10/29/15, 10:50
sys_file_reference.php:105eval int on a group field? is evaluation executed here? -
Oliver Hader commented on patch set 6 CR +1 V +1 10/29/15, 10:52
See DataHandler::getPlaceholderTitleForTableLabel which is filling a string value for an integer field. The discussion whether this makes sense is a different topic... -
Oliver Hader commented on patch set 6 10/29/15, 10:52
-
Alexander Opitz voted on patch set 6 V +2 CR +2 10/29/15, 11:02
-
Alexander Opitz merged patch set 6 10/29/15, 11:02
-
Stephan Großberndt commented on patch set 7 10/29/15, 11:08
I would have liked to vote after that info. :-/