Review TYPO3_6-2 Merged

40478[BUGFIX] Ensure filemount path has trailing slash after upgrade

Nicole Hummel CR +2 V +2 Easy +6 −2 updated 07/15/15, 15:04

Commit message

Currently the upgrade wizard for filemounts  doesn't ensure trailing
slashes for the paths. This results in "invalid value" messages if
an user edit filemounts and has to choose the correct path again. This
patch adds missing trailing slashes for paths.

Review

  • Code review CR +2
    • Frans Saris +2
    • Alexander Opitz +1
  • Verified V +2
    • Frans Saris +2
    • Alexander Opitz +1

Issues 1

Files 1

Review log 17

  1. Nicole Hummel uploaded patch set 1 06/20/15, 09:52

  2. Jan Helke voted on patch set 1 CR +1 06/20/15, 09:57

  3. Benni Mack voted on patch set 1 CR +2 06/20/15, 10:17

  4. Michael Oehlhof commented on patch set 1 CR +1 06/20/15, 10:24

    one space to much
  5. Wouter Wolters voted on patch set 1 CR +1 06/20/15, 10:27

  6. Frans Saris commented on patch set 1 06/22/15, 19:34

    FilemountUpdateWizard.php:155

    Isn't $storagePath = trim($filemount['path'], '/') . '/'; also sufficient?
  7. Nicole Hummel uploaded patch set 2 06/23/15, 08:34

  8. Wouter Wolters voted on patch set 2 CR +1 06/23/15, 08:37

  9. Frans Saris voted on patch set 2 CR +1 06/23/15, 09:29

  10. TYPO3 Bot commented on patch set 2 V -1 07/05/15, 18:31

    Github tests: failure Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/179 Service: continuous-integration/travis-ci/push Description: The Travis CI build could not complete due to an error URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/67962671 Service: continuous-integration/travis-ci/pr Description: The Travis CI build is in progress URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/69639504
  11. Alexander Opitz commented on patch set 2 07/07/15, 12:49

    TYPO3 Bots issue was composer install, so no issue with that patch.
  12. Alexander Opitz voted on patch set 2 V +1 CR +1 07/07/15, 12:50

  13. Frans Saris uploaded patch set 3 07/15/15, 13:27

  14. Frans Saris commented on patch set 3 CR +1 V +1 07/15/15, 13:28

    Made sure path / wouldn't end up as //
  15. Alexander Opitz voted on patch set 3 V +1 CR +1 07/15/15, 14:58

  16. Frans Saris voted on patch set 3 CR +2 V +2 07/15/15, 15:04

  17. Frans Saris merged patch set 3 07/15/15, 15:04