Review main Merged Breaking

40484[!!!][TASK] Remove PHP library inclusion in FE

Benni Mack CR +2 V +2 Normal +31 −46 updated 06/20/15, 12:11

Commit message

The functionality to add PHP include files
during the Frontend request is quite old and
obsolete as there are plenty of hooks available.

The functionality is in this case obsolete as it does
not apply to the design patterns we apply nowadays.

This patch removes the the library inclusion and
the associated TypoScript options and PHP function.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Daniel Maier +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Daniel Maier +1

Issues 1

Files 3

Review log 6

  1. Benni Mack uploaded patch set 1 06/20/15, 10:58

  2. Markus Klein uploaded patch set 2 06/20/15, 11:36

  3. Markus Klein voted on patch set 2 CR +1 V +1 06/20/15, 11:37

  4. Daniel Maier voted on patch set 2 CR +1 V +1 06/20/15, 11:56

  5. Wouter Wolters commented on patch set 2 V +2 CR +2 06/20/15, 11:57

    will wait with merge after Travis has been fixed.
  6. Benni Mack merged patch set 2 06/20/15, 12:11