Review main Merged Breaking

40502[!!!][TASK] Remove $GLOBALS[FILEICONS] functionality

Benni Mack CR +2 V +2 Normal +34 −87 updated 06/22/15, 18:09

Commit message

The global variable FILEICONS was used before there were
sprite icons for files prior to TYPO3 v4.4.

The $FILEICONS array is still filled on every request but
never used throughout the backend. The only usage
within BackendUtility::getFileIcon() is also never used
and thus is completely removed from the TYPO3 Core.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stephan Großberndt +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 6

Review log 8

  1. Benni Mack uploaded patch set 1 06/20/15, 21:06

  2. Stephan Großberndt voted on patch set 1 CR +1 06/20/15, 23:04

  3. Wouter Wolters commented on patch set 1 06/21/15, 12:27

    Breaking-67654-RemoveGLOBALSFILEICONSFunctionality.rst:8

    the sprite icons
  4. Wouter Wolters uploaded patch set 2 06/21/15, 12:29

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 06/21/15, 12:29

  6. Stephan Großberndt voted on patch set 2 CR +1 06/21/15, 12:42

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/22/15, 18:09

  8. Christian Kuhn merged patch set 2 06/22/15, 18:09