Review main Merged Breaking

40503[!!!][TASK] Move fileicons to EXT:frontend

Benni Mack CR +2 V +2 Easy +6 −5 updated 06/23/15, 19:35

Commit message

The only usage for fileicons in TYPO3 is in the frontend
when using "filelink" (e.g. in the list of files to download).

The files are moved to the according place and merged with
the leftover places from t3skin.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • David Greiner +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • David Greiner +1

Issues 1

Files 69

Show 49 more files

Review log 20

  1. Benni Mack uploaded patch set 1 06/20/15, 21:18

  2. Wouter Wolters updated the commit message in patch set 2 06/21/15, 12:30

  3. Wouter Wolters commented on patch set 2 V +1 CR +1 06/21/15, 12:49

    Documentation will be done at once for all gfx image movements. Is on the todo list of Benni
  4. Markus Klein commented on patch set 2 06/22/15, 15:33

    ContentObjectRenderer.php:4492

    shorten namespace pls
  5. David Greiner commented on patch set 2 06/22/15, 15:50

    in ../css_styled_content/static/(v6.2)/setup.txt and in ContentObjectRenderer.php the files are referenced with ../FileIcons/.. (UpperCamelCase) Whereas the new directory in the resources folder of sysext frontend is named "fileicons". (lowercase) Should that not be the same? Another thing which makes me confused is the missing notfound_thumb.gif in Resources/Icons/FileIcons/ (handled in ContentObjectRenderer.php:4492)
  6. Christian Kuhn commented on patch set 2 06/22/15, 15:51

    david greiner has some additional concerns, let us wait for his feedback, too.
  7. David Greiner voted on patch set 2 CR -1 06/22/15, 15:51

  8. Markus Klein commented on patch set 2 CR -1 06/22/15, 15:54

    Should be marked as [!!!] as well. Just to be on the safe side.
  9. Wouter Wolters voted on patch set 2 V 0 CR -1 06/22/15, 16:47

  10. Benni Mack updated the commit message in patch set 3 06/23/15, 10:37

  11. Wouter Wolters commented on patch set 3 06/23/15, 11:26

    ContentObjectRenderer.php:4492

    TYPO3_mainDir . 'gfx/notfound_thumb.gif'
  12. Wouter Wolters uploaded patch set 4 06/23/15, 11:27

  13. Wouter Wolters commented on patch set 4 V +1 CR +1 06/23/15, 11:28

    Both issues are solved now.
  14. David Greiner commented on patch set 4 CR -1 06/23/15, 18:34

    Namespace should be shortened

    ContentObjectRenderer.php:4481

    Namespace should be shortened
  15. David Greiner uploaded patch set 5 06/23/15, 18:51

  16. Markus Klein voted on patch set 5 CR +1 V +1 06/23/15, 18:59

  17. David Greiner voted on patch set 5 CR +1 06/23/15, 19:09

  18. David Greiner voted on patch set 5 V +1 06/23/15, 19:35

  19. Wouter Wolters voted on patch set 5 V +2 CR +2 06/23/15, 19:35

  20. Wouter Wolters merged patch set 5 06/23/15, 19:35