40503[!!!][TASK] Move fileicons to EXT:frontend
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- David Greiner +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
- David Greiner +1
Issues 1
Files 69
- typo3/gfx/fileicons/css.gifdeletedbinary
- typo3/gfx/fileicons/folder.gifdeletedbinary
- typo3/gfx/csv.gifdeletedbinary
- typo3/gfx/default.gifrenamedbinary
- typo3/sysext/backend/Classes/Utility/IconUtility.php+1 −1
- typo3/sysext/css_styled_content/static/v6.2/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/setup.txt+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php3+3 −2
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/3ds.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/ai.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/ani.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/au.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/avi.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/bmp.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/cdr.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/CREDITS.txtrenamed+0 −0
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/css.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/csv.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/default.gifcopiedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/doc.gifrenamedbinary
Show 49 more files
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/dtd.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/eps.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/exe.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/fh3.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/flash.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/folder.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/gif.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/htm.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/html.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/html1.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/html2.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/html3.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/ico.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/inc.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/java.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/jpg.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/js.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/max.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/mid.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/mov.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/mp3.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/mpeg.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/mpg.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/pcd.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/pcx.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/pdf.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/php3.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/png.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/ppt.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/ps.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/psd.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/rtf.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/sgml.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/swf.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/sxc.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/sxw.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/t3d.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/t3x.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/tga.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/tif.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/tmpl.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/ttf.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/txt.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/wav.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/wrl.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/xls.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/xml.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/xsl.gifrenamedbinary
- typo3/sysext/frontend/Resources/Public/Icons/FileIcons/zip.gifrenamedbinary
Review log 20
-
Benni Mack uploaded patch set 1 06/20/15, 21:18
-
Wouter Wolters updated the commit message in patch set 2 06/21/15, 12:30
-
Wouter Wolters commented on patch set 2 V +1 CR +1 06/21/15, 12:49
Documentation will be done at once for all gfx image movements. Is on the todo list of Benni -
Markus Klein commented on patch set 2 06/22/15, 15:33
ContentObjectRenderer.php:4492shorten namespace pls -
David Greiner commented on patch set 2 06/22/15, 15:50
in ../css_styled_content/static/(v6.2)/setup.txt and in ContentObjectRenderer.php the files are referenced with ../FileIcons/.. (UpperCamelCase) Whereas the new directory in the resources folder of sysext frontend is named "fileicons". (lowercase) Should that not be the same? Another thing which makes me confused is the missing notfound_thumb.gif in Resources/Icons/FileIcons/ (handled in ContentObjectRenderer.php:4492) -
Christian Kuhn commented on patch set 2 06/22/15, 15:51
david greiner has some additional concerns, let us wait for his feedback, too. -
David Greiner voted on patch set 2 CR -1 06/22/15, 15:51
-
Markus Klein commented on patch set 2 CR -1 06/22/15, 15:54
Should be marked as [!!!] as well. Just to be on the safe side. -
Wouter Wolters voted on patch set 2 V 0 CR -1 06/22/15, 16:47
-
Benni Mack updated the commit message in patch set 3 06/23/15, 10:37
-
Wouter Wolters commented on patch set 3 06/23/15, 11:26
ContentObjectRenderer.php:4492TYPO3_mainDir . 'gfx/notfound_thumb.gif' -
Wouter Wolters uploaded patch set 4 06/23/15, 11:27
-
Wouter Wolters commented on patch set 4 V +1 CR +1 06/23/15, 11:28
Both issues are solved now. -
David Greiner commented on patch set 4 CR -1 06/23/15, 18:34
Namespace should be shortenedContentObjectRenderer.php:4481Namespace should be shortened -
David Greiner uploaded patch set 5 06/23/15, 18:51
-
Markus Klein voted on patch set 5 CR +1 V +1 06/23/15, 18:59
-
David Greiner voted on patch set 5 CR +1 06/23/15, 19:09
-
David Greiner voted on patch set 5 V +1 06/23/15, 19:35
-
Wouter Wolters voted on patch set 5 V +2 CR +2 06/23/15, 19:35
-
Wouter Wolters merged patch set 5 06/23/15, 19:35