40508[FEATURE] Introduce Data Processor for Files
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Wouter Wolters +1
- Frans Saris +1
-
Verified V +2
- Andreas Kienast +2
- Wouter Wolters +1
- Frans Saris +1
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-67662-DataProcessorForFiles.rst7new+60 −0
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php11+78 −214
- typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php10new+114 −0
- typo3/sysext/frontend/Classes/Resource/FileCollector.php22new+307 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+39 −11
Review log 35
Show 10 earlier messages
-
Benni Mack uploaded patch set 1 06/21/15, 13:45
-
Sascha Egerer commented on patch set 1 CR -1 06/26/15, 06:37
Is it save to remove all these public function from the FilesContentObject? Shouldn't they get deprecated first? Is there a reason why not to add `array` as type for function parameters that must be of type array? I would add them in all these functions.FilesContentObject.php:43move that line down to line 72FilesProcessor.php:53Move that line into the if condition and change the condition to !empty($processorConfiguration['references.'])FilesProcessor.php:90Check if key exists before using it?FilesProcessor.php:97That should reuslt in a syntax error?!FileCollector.php:184be consistent and add @return voidFileCollector.php:246Add type to $file parameterFileCollector.php:262add empty line above @return and change array to FileInterface[] -
Sascha Egerer commented on patch set 1 06/26/15, 06:39
And Unit tests must be adjusted... but yes - patch is WIP. -
Patrick Broens commented on patch set 1 CR -1 06/26/15, 10:03
FilesProcessor.php:58There is no variable $referenceField, probably should be $relationFieldFilesProcessor.php:68Typo: This should be 'files' -
Sascha Egerer uploaded patch set 2 06/26/15, 15:49
-
Sascha Egerer commented on patch set 1 CR +1 06/26/15, 15:55
FilesContentObject.php:43ReplyDoneFilesProcessor.php:53ReplyDoneFilesProcessor.php:58ReplyDoneFilesProcessor.php:61$collections does also not existFilesProcessor.php:68ReplyDoneFilesProcessor.php:90ReplyDoneFileCollector.php:184ReplyDoneFileCollector.php:246ReplyDoneFileCollector.php:262ReplyDone -
Benni Mack uploaded patch set 3 07/07/15, 05:48
-
Nicole Hummel commented on patch set 3 V -1 07/07/15, 06:14
Failing unit tests. See https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/jobs/69840588 -
Frans Saris uploaded patch set 4 07/07/15, 10:39
-
Andreas Kienast commented on patch set 4 CR -1 07/07/15, 10:58
Unit tests are failing: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/jobs/69872027#L454
-
Frans Saris commented on patch set 4 CR -1 07/07/15, 11:31
I'm working on it -
Frans Saris uploaded patch set 5 07/07/15, 12:04
-
Frans Saris uploaded patch set 6 07/07/15, 12:14
-
Frans Saris voted on patch set 6 CR +1 V +1 07/07/15, 12:15
-
Wouter Wolters commented on patch set 6 CR -1 07/07/15, 12:31
FilesContentObject.php:88missing typeFilesContentObject.php:159@param FileCollector $fileCollectorFilesContentObject.php:162typehint?FileCollector.php:226one tab extraFileCollector.php:230here too -
Frans Saris commented on patch set 6 07/07/15, 14:50
FilesContentObject.php:88ReplyDoneFilesContentObject.php:159ReplyDoneFilesContentObject.php:162ReplyDoneFileCollector.php:226ReplyDone -
Frans Saris uploaded patch set 7 07/07/15, 14:50
-
Benni Mack uploaded patch set 8 07/07/15, 16:12
-
Benni Mack voted on patch set 8 CR +1 V +1 07/07/15, 16:12
-
Frans Saris voted on patch set 8 CR +1 V +1 07/07/15, 16:15
-
Benni Mack voted on patch set 8 CR 0 V 0 07/07/15, 16:21
-
Benni Mack commented on patch set 8 CR +1 V +1 07/07/15, 16:22
one more reviewer please, as Frans and me did this patch together. -
Wouter Wolters commented on patch set 8 07/07/15, 17:39
Sorry, spotted one more improvement hereFilesContentObject.php:42we can count this once and use it in both cases count($fileObjects) -
Wouter Wolters uploaded patch set 9 07/07/15, 21:22
-
Wouter Wolters voted on patch set 9 V +1 CR +1 07/07/15, 21:22
-
Frans Saris voted on patch set 9 CR +1 V +1 07/08/15, 05:45
-
Andreas Kienast voted on patch set 9 CR +1 07/08/15, 06:30
-
Andreas Kienast voted on patch set 9 CR +2 V +2 07/08/15, 06:39
-
Andreas Kienast merged patch set 9 07/08/15, 06:39
-
Sascha Egerer commented on patch set 9 07/08/15, 07:01
Feature-67662-DataProcessorForFiles.rst:22I would change that to the nested syntax as this is better understandable. Ok for you? tt_content.image.20 { ... }Feature-67662-DataProcessorForFiles.rst:38Can't we use nested syntax here instead of comma seperated list? tt_content.image.20.dataProcessing.10.folders { 10 = 1:introduction/images/ 20 = 1:introduction/posters/ }Feature-67662-DataProcessorForFiles.rst:40new & last lineFeature-67662-DataProcessorForFiles.rst:44line break as aboveFeature-67662-DataProcessorForFiles.rst:48not definedFilesContentObject.php:35force array by adding type infront of $conf?FileCollector.php:69force array typeFileCollector.php:70we don't need that empty statement.FileCollector.php:112same as above.FileCollector.php:127same as aboveFileCollector.php:141same as aboveFileCollector.php:168same as aboveFileCollector.php:181$folderIentifier != '' as a $folderIdentifier with value 0 would fail here, right?FileCollector.php:185we don't need the $files variable hereFileCollector.php:208do we really need the @?FileCollector.php:222Switch should always have a default. Is there nothing to do if the sortingOrder is ascending? (Sorry, have not checked the logic yet) -
Andreas Kienast commented on patch set 9 07/08/15, 07:25
FileCollector.php:208ReplyWe supress the "Array was modified by the user comparison function" warningFileCollector.php:222ReplyNo, because "ascending" is handled with the sort() above -
Andreas Kienast commented on patch set 9 07/08/15, 07:35
Feature-67662-DataProcessorForFiles.rst:38ReplyThis wouldn't work with the current implementation. -
Andreas Kienast commented on patch set 9 07/08/15, 07:41
FileCollector.php:181ReplyA folder identifier is at least prefixed with the storage uid and a colon. -
Frans Saris commented on patch set 9 07/08/15, 07:42
Feature-67662-DataProcessorForFiles.rst:38ReplyThis would indeed be nice but a new patch IMO -
Sascha Egerer commented on patch set 9 07/10/15, 06:38
FilesContentObject.php:35ReplyIt's not possible to change that without changing the abstract class which then requires that all classes, that implement the abstract class, have to be adjusted as well. Third party Content objects get incompatible too so... i would keep it for now as it is.