Review main Merged

40521Revert "[TASK] Port toolbar dropdowns to Fluid"

Christian Kuhn CR +2 V +2 Hard +154 −396 updated 06/23/15, 20:13

Commit message

This reverts commit 13d0fcc0c27ff27f3498ebda2cbd2f22f12492ab.

Moving these tiny html snippets to fluid
gives no real benefit.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Benni Mack +1

Files 14

Review log 8

  1. Christian Kuhn updated the commit message in patch set 2 06/22/15, 09:19

  2. Benni Mack commented on patch set 2 CR +1 V +1 06/22/15, 09:20

    Let's get it back to non-FLUID until we decided (on next ACME) on how to deal with Fluid for the Backend.
  3. Christian Kuhn commented on patch set 2 CR +1 V +1 06/23/15, 19:24

    After a hard fight with Markus (he now misses a leg, and I miss an ear), we decided to actually merge this revert and kick the abstract with a dedicated follow-up patch. The topic will be sorted out at acme, to decide on how to proceed with such smallish html stuff in the future.
  4. Markus Klein voted on patch set 2 CR +1 06/23/15, 19:27

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 06/23/15, 19:28

  6. Andreas Kienast voted on patch set 2 CR +2 V +2 06/23/15, 19:29

  7. Andreas Kienast merged patch set 2 06/23/15, 19:29

  8. Felix Kopp commented on patch set 3 06/23/15, 20:13

    This is a wise decision imo