40521Revert "[TASK] Port toolbar dropdowns to Fluid"
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Markus Klein +1
- Wouter Wolters +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2
- Andreas Kienast +2
- Wouter Wolters +1
- Christian Kuhn +1
- Benni Mack +1
Files 14
- typo3/sysext/backend/Classes/Backend/ToolbarItems/AbstractToolbarItem.php+8 −28
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+10 −19
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php+18 −24
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+41 −63
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+4 −5
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+25 −28
- typo3/sysext/backend/Resources/Private/Templates/ToolbarMenu/ClearCache.htmldeleted+0 −9
- typo3/sysext/backend/Resources/Private/Templates/ToolbarMenu/Help.htmldeleted+0 −10
- typo3/sysext/backend/Resources/Private/Templates/ToolbarMenu/Shortcut.htmldeleted+0 −30
- typo3/sysext/backend/Resources/Private/Templates/ToolbarMenu/User.htmldeleted+0 −16
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+28 −50
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarMenu/Opendocs.htmldeleted+0 −45
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+20 −37
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarMenu/WorkspaceSelector.htmldeleted+0 −32
Review log 8
-
Christian Kuhn updated the commit message in patch set 2 06/22/15, 09:19
-
Benni Mack commented on patch set 2 CR +1 V +1 06/22/15, 09:20
Let's get it back to non-FLUID until we decided (on next ACME) on how to deal with Fluid for the Backend. -
Christian Kuhn commented on patch set 2 CR +1 V +1 06/23/15, 19:24
After a hard fight with Markus (he now misses a leg, and I miss an ear), we decided to actually merge this revert and kick the abstract with a dedicated follow-up patch. The topic will be sorted out at acme, to decide on how to proceed with such smallish html stuff in the future. -
Markus Klein voted on patch set 2 CR +1 06/23/15, 19:27
-
Wouter Wolters voted on patch set 2 V +1 CR +1 06/23/15, 19:28
-
Andreas Kienast voted on patch set 2 CR +2 V +2 06/23/15, 19:29
-
Andreas Kienast merged patch set 2 06/23/15, 19:29
-
Felix Kopp commented on patch set 3 06/23/15, 20:13
This is a wise decision imo