Review main Merged Breaking

40574[!!!][TASK] RTE: Remove synchronous load from plugin API

Christian Kuhn CR +2 V +2 Easy +2 −32 updated 06/23/15, 20:51

Commit message

This information is never used for anything.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 6

  1. Christian Kuhn uploaded patch set 1 06/23/15, 20:21

  2. Christian Kuhn commented on patch set 1 06/23/15, 20:22

    Hint: Strictly speaking, this patch is breaking and would require a .rst file. But: More patches in this area will come, and I'll later add a general "the rte plugin api changed" breaking .rst, as soon as the main parts are done. If that is ok for you reviewers, I'd go this path, however, if you want this sorted out now, I can also add a .rst now.
  3. Wouter Wolters voted on patch set 1 V +1 CR +1 06/23/15, 20:32

  4. Frank Nägler voted on patch set 1 CR +1 06/23/15, 20:48

  5. Frank Nägler voted on patch set 1 V +2 CR +2 06/23/15, 20:51

  6. Frank Nägler merged patch set 1 06/23/15, 20:51