40599[!!!][TASK] Drop additional palette handling
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Alexander Opitz +1
- Markus Klein +1
-
Verified V +2
- Anja Leichsenring +2
- Alexander Opitz +1
- Markus Klein +1
Issues 1
Files 19
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+5 −26
- typo3/sysext/core/Classes/Migrations/TcaMigration.php16+60 −3
- typo3/sysext/core/Classes/Resource/Collection/FileCollectionRegistry.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php4+73 −32
- typo3/sysext/core/Configuration/TCA/sys_category.php+5 −1
- typo3/sysext/core/Configuration/TCA/sys_collection.php+3 −1
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+16 −6
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-67737-TcaDropAdditionalPalette.rst4new+67 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+33 −7
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+34 −44
- typo3/sysext/css_styled_content/Configuration/TCA/Overrides/tt_content.php+1 −1
- typo3/sysext/frontend/Configuration/TCA/backend_layout.php2+3 −1
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+9 −8
- typo3/sysext/frontend/Configuration/TCA/sys_domain.php+6 −2
- typo3/sysext/frontend/Configuration/TCA/sys_template.php+1 −1
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+22 −8
- typo3/sysext/rtehtmlarea/Configuration/TCA/tx_rtehtmlarea_acronym.php+7 −3
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task_group.php+4 −2
Review log 32
Show 7 earlier messages
-
Christian Kuhn uploaded patch set 1 06/24/15, 16:37
-
Christian Kuhn voted on patch set 1 CR -2 06/24/15, 16:37
-
Christian Kuhn uploaded patch set 2 06/24/15, 16:41
-
Christian Kuhn uploaded patch set 3 06/24/15, 16:47
-
Christian Kuhn commented on patch set 2 06/24/15, 16:47
ExtensionManagementUtility::addFieldsToAllPalettesOfField needs a rebrush, other than that the patch is fine already. -
Christian Kuhn uploaded patch set 4 06/24/15, 16:49
-
Christian Kuhn uploaded patch set 5 06/24/15, 20:23
-
Christian Kuhn uploaded patch set 6 06/24/15, 20:50
-
Christian Kuhn uploaded patch set 7 06/24/15, 20:56
-
Christian Kuhn commented on patch set 7 CR 0 06/24/15, 20:58
ready to review now. -
Christian Kuhn commented on patch set 7 06/24/15, 21:01
I hope I matched all core places: I did a "christmas tree all extensions enabled" test and did not get further deprecation notices after this patch. All core TCA things should be adapted to own palettes, and some palette definitions were not valid anyway. -
Christian Kuhn uploaded patch set 8 06/24/15, 21:03
-
Markus Klein commented on patch set 7 06/24/15, 21:04
Deprecation-67737-TcaDropAdditionalPalette.rst:8single backtick is MD syntax, this needs double backtickDeprecation-67737-TcaDropAdditionalPalette.rst:32-- missing? -
Markus Klein commented on patch set 8 CR -1 06/24/15, 21:20
TcaMigration.php:276Functions should have a short title as first paragraph and description in the following.TcaMigration.php:278aPaletteTcaMigration.php:285protectedTcaMigration.php:293self-explanatory, comment not neededTcaMigration.php:294self-explanatory, comment not neededTcaMigration.php:308should be !== NULL, just in case somebody called a palette "0"TcaMigration.php:310why using artificial arrays instead of simple string concat?TcaMigration.php:314same hereExtensionManagementUtility.php:406this is dangerous: showitems = 'fieldA, otherField' $field = 'field'ExtensionManagementUtility.php:420stringutil::beginswithbackend_layout.php:84is this a mistake or is that palette added dynamically somewhere? -
Christian Kuhn commented on patch set 8 06/24/15, 21:33
TcaMigration.php:276ReplyDoneTcaMigration.php:278ReplyDoneTcaMigration.php:285ReplyDoneTcaMigration.php:293ReplyDoneTcaMigration.php:294ReplyDoneTcaMigration.php:308Replygood catch.TcaMigration.php:310ReplyDoneTcaMigration.php:314ReplyDoneExtensionManagementUtility.php:406Replyyes, but should be ok. That is just a first pre-check.ExtensionManagementUtility.php:420ReplyDonebackend_layout.php:84Replypalette 1 does not exist at all. -
Christian Kuhn uploaded patch set 9 06/24/15, 21:34
-
Markus Klein commented on patch set 9 CR -1 06/24/15, 22:05
Sorry, I ran the regex \w+;;\w+[;,] over the Core and found even more occurrences. -
Alexander Opitz commented on patch set 9 CR -1 06/25/15, 06:52
Looks good, only one small hint.Deprecation-67737-TcaDropAdditionalPalette.rst:32--palette-- ? -
Christian Kuhn commented on patch set 9 06/25/15, 08:47
Deprecation-67737-TcaDropAdditionalPalette.rst:32Replyah, thx! -
Christian Kuhn commented on patch set 9 06/25/15, 08:49
markus, your regex may find false positives. i did a "christmas tree" installation with all core exts enabled and fixed all occurences that were logged. there are currently no leftovers i'm aware of. -
Christian Kuhn uploaded patch set 10 06/25/15, 08:50
-
Markus Klein commented on patch set 10 06/25/15, 09:05
my regex just helped to filter possible candidates. It does not deliver a 100% match. -
Alexander Opitz voted on patch set 10 V +1 CR +1 06/25/15, 09:28
-
Markus Klein commented on patch set 10 CR -1 06/25/15, 09:34
What about typo3/sysext/core/Classes/Resource/Collection/FileCollectionRegistry.php:86 IRRE functional tests typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:397 -
Markus Klein commented on patch set 10 06/25/15, 09:35
and typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php:166 -
Christian Kuhn commented on patch set 10 CR -1 06/25/15, 10:20
good catches, hard to find. fixing. -
Christian Kuhn uploaded patch set 11 06/25/15, 10:32
-
Markus Klein uploaded patch set 12 06/25/15, 12:43
-
Markus Klein commented on patch set 12 CR +1 V +1 06/25/15, 12:44
Fixed my comments in rst from set 7 -
Alexander Opitz voted on patch set 12 V +1 CR +1 06/25/15, 13:01
-
Anja Leichsenring voted on patch set 12 CR +2 V +2 06/25/15, 13:15
-
Anja Leichsenring merged patch set 12 06/25/15, 13:16