Review main Merged Breaking

40599[!!!][TASK] Drop additional palette handling

Christian Kuhn CR +2 V +2 Hard +352 −149 updated 06/25/15, 13:16

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Alexander Opitz +1
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Alexander Opitz +1
    • Markus Klein +1

Issues 1

Files 19

Review log 32

Show 7 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/24/15, 16:37

  2. Christian Kuhn voted on patch set 1 CR -2 06/24/15, 16:37

  3. Christian Kuhn uploaded patch set 2 06/24/15, 16:41

  4. Christian Kuhn uploaded patch set 3 06/24/15, 16:47

  5. Christian Kuhn commented on patch set 2 06/24/15, 16:47

    ExtensionManagementUtility::addFieldsToAllPalettesOfField needs a rebrush, other than that the patch is fine already.
  6. Christian Kuhn uploaded patch set 4 06/24/15, 16:49

  7. Christian Kuhn uploaded patch set 5 06/24/15, 20:23

  1. Christian Kuhn uploaded patch set 6 06/24/15, 20:50

  2. Christian Kuhn uploaded patch set 7 06/24/15, 20:56

  3. Christian Kuhn commented on patch set 7 CR 0 06/24/15, 20:58

    ready to review now.
  4. Christian Kuhn commented on patch set 7 06/24/15, 21:01

    I hope I matched all core places: I did a "christmas tree all extensions enabled" test and did not get further deprecation notices after this patch. All core TCA things should be adapted to own palettes, and some palette definitions were not valid anyway.
  5. Christian Kuhn uploaded patch set 8 06/24/15, 21:03

  6. Markus Klein commented on patch set 7 06/24/15, 21:04

    Deprecation-67737-TcaDropAdditionalPalette.rst:8

    single backtick is MD syntax, this needs double backtick

    Deprecation-67737-TcaDropAdditionalPalette.rst:32

    -- missing?
  7. Markus Klein commented on patch set 8 CR -1 06/24/15, 21:20

    TcaMigration.php:276

    Functions should have a short title as first paragraph and description in the following.

    TcaMigration.php:278

    aPalette

    TcaMigration.php:285

    protected

    TcaMigration.php:293

    self-explanatory, comment not needed

    TcaMigration.php:294

    self-explanatory, comment not needed

    TcaMigration.php:308

    should be !== NULL, just in case somebody called a palette "0"

    TcaMigration.php:310

    why using artificial arrays instead of simple string concat?

    TcaMigration.php:314

    same here

    ExtensionManagementUtility.php:406

    this is dangerous: showitems = 'fieldA, otherField' $field = 'field'

    ExtensionManagementUtility.php:420

    stringutil::beginswith

    backend_layout.php:84

    is this a mistake or is that palette added dynamically somewhere?
  8. Christian Kuhn commented on patch set 8 06/24/15, 21:33

    TcaMigration.php:276 Reply

    Done

    TcaMigration.php:278 Reply

    Done

    TcaMigration.php:285 Reply

    Done

    TcaMigration.php:293 Reply

    Done

    TcaMigration.php:294 Reply

    Done

    TcaMigration.php:308 Reply

    good catch.

    TcaMigration.php:310 Reply

    Done

    TcaMigration.php:314 Reply

    Done

    ExtensionManagementUtility.php:406 Reply

    yes, but should be ok. That is just a first pre-check.

    ExtensionManagementUtility.php:420 Reply

    Done

    backend_layout.php:84 Reply

    palette 1 does not exist at all.
  9. Christian Kuhn uploaded patch set 9 06/24/15, 21:34

  10. Markus Klein commented on patch set 9 CR -1 06/24/15, 22:05

    Sorry, I ran the regex \w+;;\w+[;,] over the Core and found even more occurrences.
  11. Alexander Opitz commented on patch set 9 CR -1 06/25/15, 06:52

    Looks good, only one small hint.

    Deprecation-67737-TcaDropAdditionalPalette.rst:32

    --palette-- ?
  12. Christian Kuhn commented on patch set 9 06/25/15, 08:47

    Deprecation-67737-TcaDropAdditionalPalette.rst:32 Reply

    ah, thx!
  13. Christian Kuhn commented on patch set 9 06/25/15, 08:49

    markus, your regex may find false positives. i did a "christmas tree" installation with all core exts enabled and fixed all occurences that were logged. there are currently no leftovers i'm aware of.
  14. Christian Kuhn uploaded patch set 10 06/25/15, 08:50

  15. Markus Klein commented on patch set 10 06/25/15, 09:05

    my regex just helped to filter possible candidates. It does not deliver a 100% match.
  16. Alexander Opitz voted on patch set 10 V +1 CR +1 06/25/15, 09:28

  17. Markus Klein commented on patch set 10 CR -1 06/25/15, 09:34

    What about typo3/sysext/core/Classes/Resource/Collection/FileCollectionRegistry.php:86 IRRE functional tests typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:397
  18. Markus Klein commented on patch set 10 06/25/15, 09:35

    and typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php:166
  19. Christian Kuhn commented on patch set 10 CR -1 06/25/15, 10:20

    good catches, hard to find. fixing.
  20. Christian Kuhn uploaded patch set 11 06/25/15, 10:32

  21. Markus Klein uploaded patch set 12 06/25/15, 12:43

  22. Markus Klein commented on patch set 12 CR +1 V +1 06/25/15, 12:44

    Fixed my comments in rst from set 7
  23. Alexander Opitz voted on patch set 12 V +1 CR +1 06/25/15, 13:01

  24. Anja Leichsenring voted on patch set 12 CR +2 V +2 06/25/15, 13:15

  25. Anja Leichsenring merged patch set 12 06/25/15, 13:16