Review TYPO3_6-2 Merged

40650[BUGFIX] Avoid race conditions in typo3temp/Cache

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 06/25/15, 15:46

Commit message

Race conditions can occur when the cache in typo3temp/Cache gets
cleared, for example by using the Install Tool "Clear all caches"
button. The cache is currently cleared using GeneralUtility::rmdir()
which does a directory traversal and unlinks all contained files.
Instead GeneralUtility::flushDirectory() should get used. This method
renames the directory into a temp-dir name and then removes the temp-dir
using GeneralUtility:rmdir().

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Alexander Opitz +1
  • Verified V +2
    • Andreas Kienast +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 4

  1. Andreas Kienast uploaded patch set 1 06/25/15, 15:42

  2. Alexander Opitz voted on patch set 1 V +1 CR +1 06/25/15, 15:44

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 06/25/15, 15:46

  4. Andreas Kienast merged patch set 1 06/25/15, 15:46