Review main Merged

40665[FOLLOWUP][TASK] Streamline pages table in PageRepository

Benni Mack CR +2 V +2 Easy +30 −1 updated 06/26/15, 08:03

Commit message

Fix unit tests which require a valid TCA for pages now (as no
bootstrapping is done in Tests, also one test was failing before
as the expected SQL was negated.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 5

  1. Benni Mack uploaded patch set 1 06/26/15, 07:58

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 06/26/15, 08:00

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 06/26/15, 08:01

  4. Benni Mack voted on patch set 1 CR +2 V +2 06/26/15, 08:03

  5. Benni Mack merged patch set 1 06/26/15, 08:03