Review main Merged

40673[FEATURE] Add TypoLinkCodec

Markus Klein CR +2 V +2 Hard +301 −0 updated 06/27/15, 14:50

Commit message

The class allows to encode or decode TypoLink strings.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 13

  1. Markus Klein uploaded patch set 1 06/26/15, 12:00

  2. Andreas Kienast commented on patch set 1 06/26/15, 12:34

    TypoLinkUtility.php:55

    does it make sense to put this into a static member, as it's used multiple times?
  3. Markus Klein commented on patch set 1 06/26/15, 12:38

    TypoLinkUtility.php:55 Reply

    Yes makes sense. Maybe also the quotes
  4. Frederic Gaus voted on patch set 1 CR +1 06/26/15, 13:10

  5. Markus Klein uploaded patch set 2 06/26/15, 14:29

  6. Markus Klein commented on patch set 2 CR -1 06/26/15, 15:49

    TypoLinkUtility.php:22

    After talking with Christian, we shall rename/reposition that class, in order to strive for all *Utilities to be static only.
  7. Markus Klein uploaded patch set 3 06/26/15, 15:59

  8. Markus Klein updated the commit message in patch set 4 06/26/15, 16:00

  9. Christian Kuhn uploaded patch set 5 06/27/15, 14:47

  10. Christian Kuhn commented on patch set 5 CR +1 V +1 06/27/15, 14:48

    renamed the thing to Service at the end ... we have that for most other services, too.
  11. Anja Leichsenring voted on patch set 5 V +1 CR +1 06/27/15, 14:50

  12. Anja Leichsenring voted on patch set 5 CR +2 V +2 06/27/15, 14:50

  13. Anja Leichsenring merged patch set 5 06/27/15, 14:50