Review main Merged

40698[TASK] Remove AbstractToolbarItem class

Anja Leichsenring CR +2 V +2 Normal +16 −54 updated 06/29/15, 06:52

Commit message

The Abstract is only implemented by one single class, so it is pretty useless.
The functionality is moved to the actual class, and the Abstract is removed.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • David Greiner +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • David Greiner +1

Issues 1

Files 2

Review log 10

  1. Anja Leichsenring uploaded patch set 1 06/27/15, 19:22

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 06/27/15, 21:47

  3. Wouter Wolters voted on patch set 1 V -1 CR -1 06/28/15, 13:35

  4. Wouter Wolters commented on patch set 1 06/28/15, 13:36

    This cannot be verified! This breaks down the BE directly. Will push an update
  5. Wouter Wolters uploaded patch set 2 06/28/15, 13:37

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 06/28/15, 13:38

  7. David Greiner voted on patch set 2 CR +1 V +1 06/28/15, 18:47

  8. Oliver Klee voted on patch set 2 CR +1 06/28/15, 19:37

  9. Andreas Kienast voted on patch set 2 CR +2 V +2 06/29/15, 06:52

  10. Andreas Kienast merged patch set 2 06/29/15, 06:52